Repository navigation
Conversation
… new restore_backup options for 5.4 Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ers, stale limitations and 5.4 release notes Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for database backup and recovery operations to align with the v5.4.0 release. The changes cover online restores using target_database, replication peer restrictions, pre-copy verification checks, crash survival behaviors, and new parameters like accept_incompatible_backup. The review feedback recommends formatting adjustments for the <VersionBadge> component, advising against its mid-sentence usage in prose and correcting its type attribute for new features.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-794 This preview will update automatically when you push new commits. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⊙ Problem
Publish every restore_backup through one crash-safe protocol (harper#3920) changes what
restore_backupdoes in 5.4, and the backup docs still describe the old behavior. They say blob files are never checked, that onlinetarget_databaseis refused, thatverify_backupdoes not open table files, and that a saved localhost login blocks an offline restore. The replicated-cluster runbook would also now fail, because a restore refuses to run while the node lists peers.❓ Your call: is a runbook step that removes the node's peers the right guidance?
harper#3920 refuses a restore while
system.hdb_nodesorreplication.routesnames a peer, even one the network has isolated. The runbook now says to remove the node's peers before restoring and add them back at re-entry. The alternative is to document an override, which the code does not have.💡 Solution
restore_backupgets a parameter table, includingaccept_incompatible_backup,accept_unverified_blobs,immutable_sourceand onlinetarget_database.verify_backupnow reads every table, and one restore or verification runs per instance.✅ Verification
npx prettier --checkpasses on all four changed files.🤖 Generated with Claude Code
Related PRs: #788 overlaps (also edits reference/backups/operations.md and overview.md)
Complexity: easy
Review-Coverage: authored=claude; ran=gemini,codex; adjudicated=domain; blocked=cursor-composer(auth); declined=cursor-grok,muse; rounds=2; full=1 @ 96a2c23
Review-Attention: skim ~2m (decisions: peer-refusal-guidance, restore-option-scope) @ 96a2c23