Skip to content

Document crash-safe restores, the restore proof and peer refusal, and the new restore_backup options for 5.4 - #794

Draft
cb1kenobi wants to merge 3 commits into
mainfrom
docs/restore-publication-protocol
Draft

cb1kenobi wants to merge 3 commits into
mainfrom
docs/restore-publication-protocol

Conversation

@cb1kenobi

@cb1kenobi cb1kenobi commented Nov 3, 2026 •

Copy link
Copy Markdown
Member
The author updating the restore manual at a library lectern

⊙ Problem

Publish every restore_backup through one crash-safe protocol (harper#3920) changes what restore_backup does in 5.4, and the backup docs still describe the old behavior. They say blob files are never checked, that online target_database is refused, that verify_backup does not open table files, and that a saved localhost login blocks an offline restore. The replicated-cluster runbook would also now fail, because a restore refuses to run while the node lists peers.

❓ Your call: is a runbook step that removes the node's peers the right guidance?

harper#3920 refuses a restore while system.hdb_nodes or replication.routes names a peer, even one the network has isolated. The runbook now says to remove the node's peers before restoring and add them back at re-entry. The alternative is to document an override, which the code does not have.

💡 Solution

✅ Verification

  • Every new claim was checked against harper#3920's code: the fence, startup recovery, the proof, pins and the child slot.
  • Two review rounds (Codex, Gemini and the Harper domain pass) converged; their findings are fixed.
  • npx prettier --check passes on all four changed files.

🤖 Generated with Claude Code

Related PRs: #788 overlaps (also edits reference/backups/operations.md and overview.md)
Complexity: easy

Review-Coverage: authored=claude; ran=gemini,codex; adjudicated=domain; blocked=cursor-composer(auth); declined=cursor-grok,muse; rounds=2; full=1 @ 96a2c23

Review-Attention: skim ~2m (decisions: peer-refusal-guidance, restore-option-scope) @ 96a2c23

cb1kenobi and others added 3 commits November 3, 2026 11:36
… new restore_backup options for 5.4

Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ers, stale limitations and 5.4 release notes

Co-Authored-By: Claude Opus 5.5 <[email protected]>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for database backup and recovery operations to align with the v5.4.0 release. The changes cover online restores using target_database, replication peer restrictions, pre-copy verification checks, crash survival behaviors, and new parameters like accept_incompatible_backup. The review feedback recommends formatting adjustments for the <VersionBadge> component, advising against its mid-sentence usage in prose and correcting its type attribute for new features.

Comment thread reference/backups/operations.md Resolved
Comment thread reference/backups/operations.md Resolved
Comment thread reference/backups/operations.md Resolved
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-794

This preview will update automatically when you push new commits.

This branch was successfully deployed

1 active deployment
pr-794 — 96a2c23e Deployed Nov 3, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant