Skip to content

Document agent.tools, the switches that turn off the agent's own tool groups, and get_agent_config - #795

Closed
DavidCockerill wants to merge 2 commits into
mainfrom
david/3993-agent-tool-switches
Closed

DavidCockerill wants to merge 2 commits into
mainfrom
david/3993-agent-tool-switches

Conversation

@DavidCockerill

@DavidCockerill DavidCockerill commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

📝 Summary

The built-in agent's tool groups (filesystem, schedule_followup, the V8 inspector, the best-practices lookup) could not be turned off. Nothing returned the agent configuration in effect. HarperFast/harper#3993 adds the agent.tools switches and the get_agent_config operation. This documents both using the harper branch claude/3993-agent-tool-switches-9d827b (PR link to follow). Every behavior claim was checked against that branch's source and tests. Version badges are v5.4.0: the feature ships in the open 5.4 line.

🔧 Changes

✅ Verification

  • npm run format:check and npm run lint pass.
  • Pre-push review: Codex graded leg and Gemini on round 1 (converged, four findings fixed: the group-exclusion claim, the self-re-enable caveat, an injected-tools parenthetical that named no real surface, the optional get_agent_config keys), then one delta round.
  • npm run build succeeds, so every new link and anchor resolves.

Refs HarperFast/harper#3993 · Refs #674 · Feature PR: the harper PR for HarperFast/harper#3993, linked here once it opens

🤖 Generated with Claude Code

Related PRs: #788 overlaps (it re-sources these four pages from the product repos; whichever lands second carries this delta into the assembled pages), 3 others independent
Complexity: easy

Review-Coverage: authored=claude; ran=gemini,codex; adjudicated=domain; blocked=muse(failed); declined=cursor-grok,cursor-composer; rounds=2; full=1 @ 8befb4f

Review-Attention: skim ~2m (decisions: malformed-tools-fail-closed-vs-fail-start, get-agent-config-outside-agent-group, drop-injected-tools-from-all-off-claim) @ 8befb4f

DavidCockerill and others added 2 commits November 3, 2026 16:05
… groups, and get_agent_config

Documents HarperFast/harper#3993: `agent.tools.filesystem`, `agent.tools.schedule`,
`agent.tools.inspector` and `agent.tools.bestPractices` remove a built-in agent tool
group at startup, with the group's names kept reserved; `set_agent_config` rejects
them; the new `get_agent_config` operation returns the configuration in effect and
is outside the `agent` permission group and MCP, like `set_agent_config`.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
…veat for agent.tools, and say which get_agent_config keys are optional

Co-Authored-By: Claude Fable 5.1 <[email protected]>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to introduce a new feature allowing users to turn off specific tool groups for the built-in Harper agent at startup (using agent.tools configuration for filesystem, schedule, inspector, and bestPractices). It also documents a new get_agent_config operation that retrieves the active agent configuration, including startup-only settings, and details how these changes affect roles, permissions, and MCP access. I have no feedback to provide as there are no review comments.

@github-actions
github-actions Bot temporarily deployed to pr-795 November 3, 2026 21:36 Inactive
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-795

This preview will update automatically when you push new commits.

@DavidCockerill

Copy link
Copy Markdown
Member Author

Closing: the reference docs are moving out of this repo (see #788), so the agent.tools and get_agent_config documentation for HarperFast/harper#3993 will land with the moved pages instead of here. The branch stays available for reuse.

— written by Claude Fable 5.1 on David's behalf

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🧹 Preview Cleanup

The preview deployment for this PR has been removed.

This branch was previously deployed

1 inactive deployment
pr-795 — 8befb4fc Deployed Nov 3, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant