Repository navigation
Explain MCP subscription expiry and renewal after credential rotation - #798
kylebernhardy wants to merge 15 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the MCP documentation and release notes to clarify how resource subscriptions behave across multiple HTTP workers, specifically detailing credential expiry preservation, reconnect restoration, and credential rotation. The review feedback suggests improving readability by splitting several long sentences containing semicolons into separate, distinct sentences to clearly isolate critical limitations and instructions.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-798 This preview will update automatically when you push new commits. |
📝 Summary
Document when MCP resource subscriptions expire and how clients renew them. Companion to Make MCP resource subscriptions reliable across HTTP workers, targeting core v5.4.
Merge dependency: keep this PR in draft until Fix scoped MCP reconnects and concurrent subscribe failures merges. Before marking ready, verify the fix is included in the actual release cut; retarget the version guidance if v5.4.0 ships without it. Its scoped-isolation guarantee is not in the already merged implementation.
🔧 Changes
Overlaps Assemble the v5 reference and open release notes from harper and harper-pro; preserve this guidance if the reference assembly lands second.
✅ Verification
🤔 Merge order
The reference describes the upcoming v5.4 behavior. Stable v5.4.0 is not tagged yet; the scoped restoration paragraph must ship with its dependent core fix.
🤔 Final review scope
Four full passes covered the four-page change. Closing checks were limited to the resulting wording fixes: cleanup advice, shared lifecycle placement, and migration responses. A further full pass would repeat the same contract review; the final change adds no API behavior.
Comment generated by kAIle (GPT-6)
Release target: main — documentation for core v5.4
Related PRs: #788 overlaps (reference assembly moves the same MCP pages)
Complexity: easy
Deferred findings
6a9846ae60efef4bnone documentation —reference/mcp/subscriptions.md— Open PR 788 overlaps the subscription documentation — filed MCP subscription state: recovery, auditing, and teardown follow-ups harper#4008414561ca18bdca0anone documentation —release-notes/v5-lincoln/5.4.md— v5.4 scoped-isolation claim depends on companion core PR 4029 — filed MCP subscription state: recovery, auditing, and teardown follow-ups harper#4008Review-Coverage: authored=codex; ran=cursor-composer,claude; adjudicated=domain; declined=gemini,cursor-grok,muse; rounds=10; full=4 @ a73e21b
Review-Attention: skim ~2m (decisions: earlier-credential-expiry, blocking-reconnect-restoration, scoped-restoration-isolation) @ a73e21b