Repository navigation
Conversation
CuiweiG
force-pushed
the
fix-touchstone-comment
branch
from
November 18, 2026 09:57
dcc58e0 to
54f53e4
Compare
The Receive workflow skips draft PRs and PRs whose author is not an owner, member or collaborator. Those runs upload no 'pr' artifact, so the comment action fails to download it and sets a failing 'touchstone comment' status on the PR. Also group Comment runs by the ID of the Receive run. github.head_ref is empty for workflow_run events, so all Comment runs shared one concurrency group and cancelled each other.
CuiweiG
force-pushed
the
fix-touchstone-comment
branch
from
November 18, 2026 10:35
54f53e4 to
3f4dd81
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarks are skipped for draft PRs and for PRs whose author is not an owner, member or collaborator. The skipped Receive run uploads no
prartifact, but the Comment workflow still runs, fails to download it (log) and sets a failingtouchstone commentstatus on the PR. Theuploadjob now runs only if the Receive run was not skipped; failed and cancelled benchmark runs still get the failing status.The concurrency group used
github.head_ref, which is empty forworkflow_runevents, so all Comment runs shared the groupContinuous Benchmarks (Comment)-and a run for one PR cancelled the run for another (run 43830386987). The group now uses the ID of the Receive run, the same change as proposed for the touchstone template in lorenzwalthert/touchstone#176.Since
workflow_runworkflows run from the default branch, this only takes effect after merging.