Skip to content

Skip touchstone comment for skipped benchmark runs - #294

Open
CuiweiG wants to merge 1 commit into
HelenaLC:develfrom
CuiweiG:fix-touchstone-comment
Open

CuiweiG wants to merge 1 commit into
HelenaLC:develfrom
CuiweiG:fix-touchstone-comment

Conversation

@CuiweiG

@CuiweiG CuiweiG commented Nov 17, 2026 •

Copy link
Copy Markdown

Benchmarks are skipped for draft PRs and for PRs whose author is not an owner, member or collaborator. The skipped Receive run uploads no pr artifact, but the Comment workflow still runs, fails to download it (log) and sets a failing touchstone comment status on the PR. The upload job now runs only if the Receive run was not skipped; failed and cancelled benchmark runs still get the failing status.

The concurrency group used github.head_ref, which is empty for workflow_run events, so all Comment runs shared the group Continuous Benchmarks (Comment)- and a run for one PR cancelled the run for another (run 43830386987). The group now uses the ID of the Receive run, the same change as proposed for the touchstone template in lorenzwalthert/touchstone#176.

Since workflow_run workflows run from the default branch, this only takes effect after merging.

The Receive workflow skips draft PRs and PRs whose author is not an
owner, member or collaborator. Those runs upload no 'pr' artifact, so
the comment action fails to download it and sets a failing
'touchstone comment' status on the PR.

Also group Comment runs by the ID of the Receive run. github.head_ref
is empty for workflow_run events, so all Comment runs shared one
concurrency group and cancelled each other.
@CuiweiG
CuiweiG force-pushed the fix-touchstone-comment branch from 54f53e4 to 3f4dd81 Compare November 18, 2026 10:35

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant