Repository navigation
Expose the first visible diff cell - #18
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gtokman
marked this pull request as ready for review
November 7, 2026 18:19
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers need a stable view for anchoring contextual presentations to a diff. Add
DiffFilesViewController.firstVisibleDiffCell, which uses the controller's collection view and item identifiers to return the first visible hunk cell in display order, skipping context expanders.The collection view remains private. Returns nil before the view loads or when no diff cell is visible.
Validation: Swift syntax parsing and
git diff --checkpassed. The consuming iOS package built successfully for the iOS 26.5 simulator against this revision. No view or layout tests were added; visual presentation QA remains outstanding.