Skip to content

Expose the first visible diff cell - #18

Merged
gtokman merged 1 commit into
mainfrom
codex/diff-cell-anchor
Nov 7, 2026
Merged

gtokman merged 1 commit into
mainfrom
codex/diff-cell-anchor

Conversation

@gtokman

@gtokman gtokman commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Consumers need a stable view for anchoring contextual presentations to a diff. Add DiffFilesViewController.firstVisibleDiffCell, which uses the controller's collection view and item identifiers to return the first visible hunk cell in display order, skipping context expanders.

The collection view remains private. Returns nil before the view loads or when no diff cell is visible.

Validation: Swift syntax parsing and git diff --check passed. The consuming iOS package built successfully for the iOS 26.5 simulator against this revision. No view or layout tests were added; visual presentation QA remains outstanding.

@vercel

vercel Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
markdown-view Ready Ready Preview, v0 Nov 2, 2026 10:08pm UTC

Request Review

@gtokman
gtokman marked this pull request as ready for review November 7, 2026 18:19
@gtokman
gtokman merged commit c1f1cab into main Nov 7, 2026
6 checks passed

This branch was successfully deployed

1 active deployment
Preview — 5912f0fd Deployed Nov 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant