Repository navigation
feat: Muni and Caltrain clients; release 2.7.0 - #16
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
mta.muni(/api/v1/muni) andmta.caltrain(/api/v1/caltrain) on the existingCommuterRailClient, adds"muni" | "caltrain"toCommuterRailMode, and bumps the version to 2.7.0.Merging publishes 2.7.0, so merge only after the matching mta-api endpoints are deployed.
bun testpasses (28 tests) and typecheck passes. Both clients were also run end to end against a local mta-api serving live 511 data.Link to Devin session: https://app.devin.ai/sessions/8d319beac0174974a184312ce7c14932
Open in Devin Desktop: https://app.devin.ai/desktop/session/8d319beac0174974a184312ce7c14932?variant=devin
Requested by: @gtokman
🟢 Devin Review found nothing to fix · View findings