Repository navigation
Conversation
Owen271
force-pushed
the
lock-direction
branch
2 times, most recently
from
November 11, 2026 07:59
1587792 to
f6202b5
Compare
Owen271
marked this pull request as ready for review
November 11, 2026 07:59
Once a swipe trigger with lock_direction has started, its angle is no longer checked, so it stays active until the gesture ends instead of being cancelled and chained into another trigger when the direction changes. Speed is still checked. A gesture resumed with resume_timeout must match the angle again before the lock applies. Defaults to false. Adds TriggerCore::canContinue, which Trigger::canUpdate uses once the trigger has been updated during the current gesture; the default implementation calls canUpdate, so other triggers are unaffected.
Owen271
force-pushed
the
lock-direction
branch
from
November 11, 2026 08:25
f6202b5 to
d89bb81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swipe triggers are cancelled when the averaged angle leaves their range, which allows chaining. For gestures that should run a single action per swipe this misfires: wobbling during an
upswipe toggles Overview twice, and a held Alt+Tab swipe is cancelled as soon as it turns.lock_direction: truechecks the angle only until the trigger starts; after that the trigger stays active until the gesture ends. Speed and thresholds are still checked, and a gesture resumed withresume_timeoutmust match the angle again. Defaults tofalse, so existing configs are unaffected.A matching wiki change is ready; I'll open it if this is accepted. Happy to rework it to fit with InputActions/discussions#272.