Repository navigation
Run the whole test suite in the conda recipes - #283
Open
antonwolfy wants to merge 3 commits into
Open
antonwolfy wants to merge 3 commits into
antonwolfy wants to merge 3 commits into
Conversation
antonwolfy
requested review from
jharlow-intel,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
October 14, 2026 12:33
jharlow-intel
previously approved these changes
Oct 15, 2026
jharlow-intel
left a comment
jharlow-intel
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks good! Running the full installed suite with --pyargs matches what mkl_fft, mkl_random, and mkl-service already do, and all 28 GitHub conda test jobs pass with it. Just one changelog note inline.
The recipes' test commands only ran test_basic.py, so test_patching.py,
test_cli.py and test_freethreading.py were never run against the conda
package. Switch both recipes to `pytest --pyargs mkl_umath`, matching
the GitHub workflows, and drop source_files since the tests are
installed with the package.
Remove the run_tests.{sh,bat} scripts: they ran test_basic.py as a plain
script, which runs no tests since it moved to pytest, and nothing calls
them, as conda-build only picks up run_test.* (singular).
antonwolfy
force-pushed
the
run-all-tests-in-conda-recipes
branch
from
October 15, 2026 17:49
cfbbaec to
7d57828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conda recipes only ran
test_basic.pyat package test time, sotest_patching.py,test_cli.pyandtest_freethreading.pywere never run against the built conda package. That also applies to internal CI jobs that reuse the recipe's test commands.This PR switches
test.commandsin bothconda-recipeandconda-recipe-cftopytest --pyargs mkl_umath, which is what the GitHub workflows already run against the installed package.source_filesis dropped becausemeson.buildinstallsmkl_umath/testswith the package.It also removes
run_tests.{sh,bat}from both recipes. They ranpython tests/test_basic.py, which runs no tests now that the file uses pytest. Nothing called them anyway: conda-build only picks uprun_test.*(singular), and no workflow invokes them.