Repository navigation
Do not set LIBRARY_PATH on Windows - #53
Merged
Merged
Conversation
jasagredo
force-pushed
the
js/library-path
branch
2 times, most recently
from
October 26, 2026 10:53
9115770 to
568cdab
Compare
carbolymer
reviewed
Oct 26, 2026
| run: | | ||
| /usr/bin/pacman --noconfirm -S mingw-w64-clang-x86_64-snappy mingw-w64-clang-x86_64-protobuf | ||
| cat <<EOF >> $GITHUB_ENV | ||
| LIBRARY_PATH=C:/msys64/clang64/lib |
Contributor
There was a problem hiding this comment.
Can this fix be extended to macos as well?
Contributor
|
LGTM |
This causes GHC to find the libc++ that was installed by the protobuf package and results in TH segfaults. Snappy can be linked with the cabal flag `+pkg-config` and for protobuf we only need the protoc compiler which is accessible via `$PATH`.
jasagredo
force-pushed
the
js/library-path
branch
from
October 26, 2026 11:36
568cdab to
b0cc1be
Compare
13 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes GHC to find the libc++ that was installed by the protobuf package and results in TH segfaults. Snappy can be linked with the cabal flag
+pkg-configand for protobuf we only need the protoc compiler which is accessible via$PATH.