Repository navigation
feat(views): relink broken View sources from the Views table and on Data Link create - #458
Open
allison-truhlar wants to merge 5 commits into
Open
allison-truhlar wants to merge 5 commits into
allison-truhlar wants to merge 5 commits into
Conversation
allison-truhlar
added this pull request to stack #429
September 29, 2026 19:08
allison-truhlar
marked this pull request as ready for review
September 29, 2026 19:17
allison-truhlar
force-pushed
the
ngviews-12-relink-ui
branch
from
September 29, 2026 19:21
021e0e3 to
8dd51ac
Compare
allison-truhlar
force-pushed
the
ngviews-12-relink-ui
branch
from
October 6, 2026 20:48
577c3f4 to
6e4b5aa
Compare
allison-truhlar
force-pushed
the
ngviews-12-relink-ui
branch
from
October 7, 2026 18:34
6e4b5aa to
ab27771
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editable-Views branch 12: the frontend for relinking broken Views. It consumes the API from #457 (
relinked_viewson Data Link create,GET /api/neuroglancer/views/relinkable,POST /api/neuroglancer/views/relink, andViewLayer.sharing_key/url_prefix). Spec:docs/superpowers/specs/2026-09-29-ngviews-editable-design.md§6.1.What changed
RelinkDialog, which relinks onto the owner's existing Data Link for that dataset if there is one, and otherwise offers "Create Data Link". Sources that can't be relinked keep the plain icon, with the tooltip "Can't relink — recreate this View".useDataToolLinksinto a shareddefaultUrlPrefix.RelinkDialogtakes aRelinkTargetso that the viewer banner planned for branch 14 can reuse it.Testing
Frontend suite green (472), prettier and eslint clean,
node-checkat the known 5-error baseline. Checked the Views table spacing and dialogs by hand in the dev app. Playwright suite not run for this branch.@krokicki