Repository navigation
fix bugs for sign of d0, calculation of residual, and calculation of position and momentum at fixed radius during CVT track finding - #1519
Merged
Conversation
…position and momentum at fixed radius during CVT track finding
tongtongcao
requested review from
raffaelladevita and
zieglerv
as code owners
October 15, 2026 19:17
raffaelladevita
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the attached slides for discussion of d0 sign convention.
Discussion for sign of d0.pdf
Besides, bugs for functions of calculation of residual and calculation of position & momentum at fixed radius are fixed.
Calculation of residual uses parameters from circular fitting, and calculation of position & momentum at fixed radius are fixed uses parameters from Helix.
As discussed in the slides, the d0 sign conventions used in circular fitting and Helix are opposite. Accordingly, the updated implementations account for this sign difference.