Repository navigation
Close internally prepared statements when execution fails - #60
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 82.40% 85.92% +3.52%
==========================================
Files 1 1
Lines 125 135 +10
==========================================
+ Hits 103 116 +13
+ Misses 22 19 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic
execute(connection, sql, params)andexecutemultiple(connection, sql, params)helpers prepare a statement internally. If execution then throws before returning a cursor, that statement was left open.Close the internally prepared statement on that failure path and rethrow. Successful results retain their existing lifetime, and explicitly supplied statements remain caller-owned. Document this ownership rule. Driver-specific connection overrides and failures while consuming a returned cursor remain outside these generic helpers.
Validation: two new cleanup assertions failed before the fix. All ten ownership assertions now pass, including successful-result and caller-owned-statement controls. Full package suites pass on Julia 1.9.4 and 1.12.6 with four threads. The regression uses the existing fake driver; no production leak measurement is claimed.
Co-authored by Codex