Repository navigation
Conversation
Collaborator
|
Your correction is valid. I think the new test is overkill. This is a new test that confirms that other tests do not waste work. I would omit it. We could simplify this even more and use a single make target to download all unicode files instead of splitting this across many make targets. I contributed that code, and in hindsight, I may have gone over the top with the makefile bits for this. I'm waiting for someone else to comment as well. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel top-level builds launch separate recursive makes for
Lowercase.txtandUppercase.txt. Both can seeDerivedCoreProperties.txtas missing and download it into the same file concurrently.Declare the shared download as a top-level prerequisite of both casing targets and the data generator, so it completes once before those recursive makes start. Add an offline regression to
make checkthat invokes realmake -j8with stand-ins for the downloader and Julia, verifies one download, and checks that both outputs are generated. The unchanged Makefile fails this test with two downloads.Fixes #234.
Validation on Linux:
make test_parallel_makeandmake -j8 test_parallel_makepass.make -j8 allbuilds the static and shared libraries.charwidth,misc,valid,iterate,case,custom, andmaxdecompositiontests pass.make checkwas not run locally because Julia is not installed.