Repository navigation
Conversation
The internal and the ioxide engine send the 100 (Continue) as the handler first reads the body, the way Kestrel does, so a handler that answers without reading never invites the upload. An unknown expectation is answered with 417, and the header is ignored on HTTP/1.0 (#928).
MDA2AV
added a commit
that referenced
this pull request
Oct 26, 2026
The 100 (Continue) handling and the 417 for other expectations move to #958, together with the compliance concern change made on top of them, so this branch stays about the ioxide update; these files are back to main.
Owner
|
Implemented via #965 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #953, which stays about the ioxide update.
A request that carries
Expect: 100-continuenever got a100 Continueback on the internal or the ioxide engine, so the client waited out its own timeout before sending the body anyway - a second for curl, which adds the header to every HTTP/1.1 upload over 1 MB (#928).Expect: 100-continueon HTTP/1.1 with100 Continueas the handler first reads the body, the way Kestrel does - a handler that answers without reading (a 401, a 413) never invites the upload. The body reads through aContinueReaderover the connection's reader, which writes the 100 on its first read and is disarmed once the final response starts, since no interim response may follow a final one.417 Expectation Failed, in the shared compliance concern, so on every engine. The header is ignored on HTTP/1.0, and on a request without a body, which has nothing to wait for.Verification
main, net11.0: 2,618 passed, 0 failed, 4 skipped; net10.0: 2,615 passed, 0 failed, 4 skipped.ExpectContinueTests, 18 cases across the three engines. The 100-continue cases were run with the fix disabled and fail without it; the 417 and HTTP/1.0 cases are controls. Kestrel answers 100-continue itself, so those cases pass there either way.Closes #928