Repository navigation
Conversation
…lasses When compiling, one now gets back an Executable, which can be run. Program is now an immutable representation of a program (with a small, thread-safe cache of compilation results). The old class Executable was no longer needed, so its name was stolen for the new class.
Symlinks in compilation artifacts is not well supported in judge systems like Kattis. A build step creating more esoteric file objects is likely a bug (or exploitation attempt).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ends up a bit large, but it was hard to split this in a good way.
The main point of this PR is to split the concerns of the old, overloaded
Programclass, which is the main component of therunmodule.Functional changes:
Main points of refactor:
Programnow represents a program prior to compilation. You cannot run a program, you can only compile it.Executablenow represents something you can run (there was an earlier class with this name. It's now gone, and the name has been stolen)Executableinstead ofProgramin several places, giving slightly improved handling of some error conditions when key things fail to compileProgramto different directories actually works now (instead of just pretending to work, due to caching :)ProgramErrorexception is gone - everything is now an error in the compile stepExecutable, making things a bit cleanergit diff --color-movedmay be helpful in reviewing. The large, ugly-looking__run_waitmethod has simply moved fromProgramtoExecutable