Repository navigation
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Kernels that fail to launch are silently ignored by the nvcuda backend instead of raising an exception.
cuda-pythonreturns a tuple from every call, even for calls that only return a status, e.g.cuLaunchKernelreturns a tuple of length 1(CUresult,).cuda_error_checkassumes that its input is the error code, not a tuple. As a result, kernels that failed to launch were just ignored.This PR changes
cuda_error_checkto unwrap tuples before checking the status. It is also raises aTypeErrorwhen given anything that is not a CUDA driver, runtime or NVRTC status.