Skip to content

[Feature] Add a Shortcuts settings page to change any command's keys - #45

Merged
KieranP merged 1 commit into
mainfrom
github-44
Nov 19, 2026
Merged

KieranP merged 1 commit into
mainfrom
github-44

Conversation

@KieranP

@KieranP KieranP commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Closes #44

Settings > Shortcuts lists each menu command beside its default and records new keys in place. The menu bar, the terminal's unbinds and the text that quotes keys all follow a change.

  • Saved: only changes, under shortcuts in the state file. The decode drops a bad entry alone.
  • Refused: keys every text field or pane needs, and keys macOS or AppKit keeps (the reserved table). The row says why. Keys without ⌘ are allowed with a warning naming what the shell loses.
  • Taken: keys another command holds ask Replace or Cancel, and so does the reset arrow.
  • Fixed: Undo, Redo, Find and the clipboard four can't change. Only the clipboard four stay bound in panes.
  • Command line: config global takes shortcuts.<command>.
  • Sidebar: a split settings page lists its parts only while it is open.

Decisions and what was reviewed and left as is: Docs/design/shortcuts.md.

Test plan

  • make test: 3,210 tests pass
  • make lint
  • Debug build driven through the helper on a scratch home: an override reaches the live menu item, ⌘Q is refused, screenshots of the Edit and Terminal parts and of the collapsed sidebar
  • By hand: record keys on the page, Replace, Restore Defaults
  • By hand, unproven here: a non-US layout (AZERTY, Russian), and holding a key you just recorded

🤖 Generated with Claude Code

Every key was fixed in the app's catalogue, so someone used to ⌘K for a
switcher or ⌘\ for a split had no way to say so. Settings > Shortcuts
lists each menu command beside its default, records new keys in place,
and the menu bar, the terminal's unbinds and the text quoting keys all
follow the change.

- Only changes are saved, under `shortcuts` in the state file
- Refused keys say why; keys without ⌘ warn what a pane loses
- Keys another command holds ask Replace or Cancel first
- Undo, Redo, Find and the clipboard commands keep their keys
- `config global` takes `shortcuts.<command>`
- A split settings page lists its parts only while it is open

Closes #44

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@KieranP
KieranP enabled auto-merge (squash) November 19, 2026 05:01
@KieranP
KieranP merged commit 1fbbb21 into main Nov 19, 2026
3 of 4 checks passed
@KieranP
KieranP deleted the github-44 branch November 19, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change any command's keyboard shortcut in Settings

1 participant