Skip to content

fix(cli): polish 'engines' after #935 - #977

Merged
KnifeLemon merged 1 commit into
KnifeLemon:mainfrom
yavuzmeteafsar:fix/cli-engines-polish
Nov 1, 2026
Merged

KnifeLemon merged 1 commit into
KnifeLemon:mainfrom
yavuzmeteafsar:fix/cli-engines-polish

Conversation

@yavuzmeteafsar

Copy link
Copy Markdown
Contributor

What does this change?

The small polish points from the review of #935:

  1. Table width: the filee engines list sizes its columns to the longest value, so a long version such as Tesseract's 5.4.0.20240606 on Windows no longer pushes SIZE out of line. New test: The_list_columns_fit_a_long_version.
  2. JSON version for an own copy: I kept the field and documented it in filee help engines: it is the version Filee downloads, also next to owncopy. A front end needs it to offer Filee's tested version over a copy found on the PC (install allows that), and it keeps the JSON shape from feat(cli): add 'engines' to list, install and remove optional engines #935 unchanged.
  3. Test name: Engines_go_to_the_apps_engines_folder. DownloadRoot is read once at startup, so the test can't change FILEE_DATA_DIR itself; A_separate_data_folder_keeps_its_own_engines in the Engines tests covers that part.
  4. Style: Report checks --json once (if/else), and the header comment of Cli.cs gives the exit codes as filee help does.

Type of change

  • Bug fix
  • New feature or improvement
  • New format or engine
  • Translation
  • Documentation
  • Build, CI or dependencies

How was it tested?

  • dotnet format --verify-no-changes (Filee.Cli, Filee.Cli.Tests)
  • dotnet test (Filee.Cli.Tests)
  • Tried it in the app: filee engines on macOS (Apple Silicon)

Checklist

  • New UI strings are in all src/Filee.App/Assets/i18n/*.json files (none added)
  • New third-party code or binaries are listed in THIRD-PARTY-NOTICES.md (none)
  • The PR does one thing (unrelated changes go in a separate PR)

Thanks for the quick and clear reviews on #714, #759 and #935. It's been a pleasure working on Filee, and I'd like to keep contributing regularly. With the CLI items from #582 done, I'm happy to pick up open issues, especially around the CLI, the engines and macOS, which I can test on Apple Silicon. If there are issues you'd like help with, feel free to assign them to me or tag me.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XTVDtoJtVjfqPJaMZu8wLh

From the review of KnifeLemon#935:

- The list sizes its columns to the longest value, so a long version
  (Tesseract's 5.4.0.20240606 on Windows) no longer pushes SIZE out of line.
- 'filee help engines' says what "version" means in the JSON: the version
  Filee downloads, also next to "owncopy".
- The FILEE_DATA_DIR test is named for what it checks.
- Report checks --json once, and the header of Cli.cs gives the exit codes
  as 'filee help' does.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01XTVDtoJtVjfqPJaMZu8wLh
@github-actions github-actions Bot added the bug Something isn't working label Nov 1, 2026

@KnifeLemon KnifeLemon left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yavuzmeteafsar. All four points are covered:

  • the columns now take their width from the rows, with a test for a long version;
  • version next to owncopy is documented in filee help engines, which is the better choice, since a front end needs Filee's version there;
  • the test name matches what it checks;
  • --json is checked once, and the header comment matches filee help.

CI is green. Merging.

@KnifeLemon
KnifeLemon merged commit 89d022d into KnifeLemon:main Nov 1, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants