Repository navigation
fix: make npm run typecheck pass under TypeScript 7 - #62
Merged
Merged
Conversation
|
Thanks for the contribution! 🙌 If you find this list useful, could you give the repository a ⭐ star? It really helps us keep it growing. |
atherdon
force-pushed
the
fix/typecheck-tsx-errors
branch
from
October 31, 2026 07:59
41e05e9 to
8a9f4e2
Compare
- Inline tsconfig (drop @docusaurus/tsconfig baseUrl, removed in TS 7) - Type search theme entry as PluginConfig - Import JSX namespace from react in page components - Drop removed useBaseUrl locale option (was already a no-op at runtime) Co-authored-by: petroved <[email protected]>
atherdon
force-pushed
the
fix/typecheck-tsx-errors
branch
from
October 31, 2026 08:06
d1496e3 to
fb0558c
Compare
atherdon
marked this pull request as ready for review
October 31, 2026 08:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minimal TypeScript fixes so
npm run typecheckpasses with the TS 7 / #58-style tsconfig (no content/copy changes).Changes
tsconfig.json— inline compiler options (TS 7 rejectsbaseUrlfrom@docusaurus/tsconfig)docusaurus.config.js— type local-search theme asPluginConfigsrc/pages/*—import type {JSX} from 'react'; replace removeduseBaseUrl(..., {locale})with/uk/docs/getting-startedMerge order
Land before #58 (typecheck adopter). #58 will be rebased onto this branch so it only needs the workflow.
Test plan
npm run typecheckclean