Skip to content

chore(deps): update Azure commitments module - #2135

Open
cristim wants to merge 1 commit into
mainfrom
codex/go76-cli-azure-rollout
Open

cristim wants to merge 1 commit into
mainfrom
codex/go76-cli-azure-rollout

Conversation

@cristim

@cristim cristim commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Why

The CLI still resolves the older Azure commitments module. This PR updates only the direct Azure module version and the Go-generated checksums, so its existing helper can consume the reservation cost semantics in the reviewed Azure pricing stack. AWS, GCP and the effective shared pkg module remain at their prior selected versions. Current production CLI service dispatch in cmd/main.go constructs AWS clients only; this pin does not enable a user-facing Azure CLI command path.

Evidence

  • Published Azure module v0.0.0-20261004143708-56555e1be095 was fetched through the public Go proxy and authenticated by Go's module and go.mod checksums.
  • A scratch overlay passed a concrete Azure client through the CLI's existing executePurchase path. With the prior module, both named monthly and upfront cases completed three in-memory HTTP requests, then failed only the cost assertions because the returned JSON cost was 2000. With the new module, both passed: monthly cost 0, upfront cost null.
  • The selected four existing mock-backed CLI tests passed under -race -short. Offline module-graph inspection selected the intended Azure version and unchanged AWS, GCP and shared pkg versions. The CLI command package built to a scratch output. go mod tidy -diff was clean after Go-generated checksum updates.
  • The ordinary commit hooks passed, including tidy, file checks, git-secrets and Trivy. Hooks without matching staged files were skipped normally.
  • An independent gpt-6-astra exact-commit review of 9f7b722702cb184ebc15ef7445768ba055281330 found no actionable implementation issue. The reviewer inspected the full two-manifest change, the cached old-to-new Azure source delta and module authentication, then independently reran the two synthetic concrete-client cases. Both passed; preserved local treatment log /tmp/claude/astra-go76-cli-committed-treatment-v1.log has SHA256 abee382ef63dceace6125177002498a081d9c32a21cad76ff65778d0c6e428f7. Prior baseline and build logs were inspected, not independently rerun.

The HTTP requests above used strict synthetic responses and a fake credential. This is helper-level dependency integration through executePurchase, not normal CLI Azure command dispatch, a live Azure catalog, reservation purchase, matching-order re-drive, or full CLI acceptance result. PR-triggered CI must still be observed; no green CI claim is made here.

Dependency and scope

This consumer PR depends on the still-open Azure pricing stack PR #187 and its ancestors. Do not merge it ahead of the upstream stack or treat fixture-backed evidence as the remaining real-scenario acceptance. It is one CLI dependency pin, not the full fix for cloud-commitments-go #76 or #132. Both remain open. Refs LeanerCloud/cloud-commitments-go#76 and LeanerCloud/cloud-commitments-go#132.

Summary by CodeRabbit

  • Chores
    • Updated an Azure integration dependency.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 39d6f237-e402-480e-b2b7-432e4c320572
📥 Commits

Reviewing files that changed from the base of the PR and between 652fc94 and 9f7b722.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The Azure provider dependency version in go.mod changes from v0.0.0-20260928214714-ce9513612901 to v0.0.0-20261004143708-56555e1be095.

Changes

Azure provider dependency

Layer / File(s) Summary
Update Azure provider dependency
go.mod
The Azure provider dependency version changes to v0.0.0-20261004143708-56555e1be095.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 9f7b7

This updates the Azure provider dependency without adding an Azure CLI dispatch path; no concrete user-facing or production-path risk is evident. The change appears mergeable after normal CI checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the Azure commitments module dependency update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim cristim added triaged Item has been triaged urgency/this-sprint Within the current sprint priority/p1 Next up; this sprint severity/high Significant harm impact/many Affects most users effort/m Days type/bug Defect labels Oct 4, 2026
@cristim

cristim commented Oct 4, 2026

Copy link
Copy Markdown
Member Author

Exact-head CI for 9f7b722702cb184ebc15ef7445768ba055281330 is green: Build & Test run 37220023579 completed with all eight jobs successful, and pre-commit run 37220023599 completed successfully. This does not clear the upstream Azure PR stack, real-scenario acceptance, or the existing AWS-only production CLI dispatch limitation; this PR remains open and merge-held.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/m Days impact/many Affects most users priority/p1 Next up; this sprint severity/high Significant harm triaged Item has been triaged type/bug Defect urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant