Repository navigation
fix: escape single quotes in test-case input for POSIX shells - #1032
Open
sivaharish31 wants to merge 1 commit into
Open
sivaharish31 wants to merge 1 commit into
sivaharish31 wants to merge 1 commit into
Conversation
The parseTestString() function wraps custom test input in single quotes for Bash/WSL but does not escape embedded single quotes. An input like it's produces a shell parse error, and ['a','b'] silently becomes [a,b] because Bash strips the inner quotes. Apply the standard POSIX '\'' escape pattern for the Bash/WSL branch and the '' doubling convention for the PowerShell branch. Add a standalone regression test verifying 13 inputs through actual Bash and CMD shell execution. Fixes LeetCode-OpenSource#1031
sivaharish31
force-pushed
the
fix/test-input-single-quote-escaping
branch
from
October 22, 2026 07:07
1d6c06b to
ec22895
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
node test/verify-quoting.js— 26/26 cases passed across Git Bash and Windows CMD, with exact argument comparisons.npx tsc -p ./ --skipLibCheck— passed.npx tslint --project tsconfig.json -e 'src/*.d.ts' -t verbose— passed.Limitations
parseTestString()function, because the module requires the VS Code extension host.Fixes #1031