Repository navigation
Add regression test for final_gen_send PERSIS_STOP with empty H_rows - #1793
Merged
Merged
Conversation
…or the resource manager hasn't yet been started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a unit-level regression test covering the bug fixed in a5dd111:
Manager._send_work_orderpreviously gated the entirePERSIS_STOP/final_gen_sendmeta-message behindlen(work_rows), so when a persistent generator was stopped with zero pending rows (e.g. idle shutdown), the manager sent nothing and the worker hung forever inPersistentSupport.recv().This was discovered while testing #1737 (libE service mode), but the bug/fix live in core manager code, so this test targets
developdirectly rather than that feature branch.Changes
libensemble/tests/unit_tests/test_manager_main.py: adds aFakeCommhelper andtest_send_work_order_persis_stop_empty_rows, which exercisesManager._send_work_orderdirectly with aPERSIS_STOPwork order and emptyH_rows, asserting the meta-message is still sent.Testing
_send_work_order/PersistentSupport.recv()and passes with the fix (already on develop).black/flake8clean.