Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions docs/desktop/independent-review/res644-review.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# RES-644 independent engineering review — 2026-11-12

Reviewed the eight-commit stack against `origin/main` (`2e9f53c`), including persistence, facade, worker guards, native History and qualification reports. PR #3 targets main; RES-647 remains separate above it. No statistical algorithm or acceptance threshold changed.

Confirmed defect: append created derived Parquet directories before the SQLite reference and left them behind after a validation, materialization or transaction exception. The repair removes only the generated directory for an uncommitted attempt. Existing committed revisions and admitted inputs remain byte-identical. Injected Parquet and audit/transaction failures both roll back; retry succeeds. Abrupt process termination can still leave an unreferenced directory; it cannot be selected as a revision. Automatic deletion on startup is deliberately avoided because another process may be materializing there.

Reviewed contracts: additive transactional schema v2; versioned entity documents; explicit participant-ID confirmation; source/rights/schema/instrument/calibration/timebase compatibility; separate attachments without pooling; captured revisions and frozen cohort/plan versions; computation outside the preparation transaction; stale completion rejection; transactional report freezing and rendering from frozen context. Historical runs and reports are not rewritten.

Validation: nine targeted workspace tests passed. Full Python/scientific/Qt regression on repaired source: **292 passed in 347.60 seconds**; `QT_QPA_PLATFORM=offscreen`, Python 3.12.13, Qt 6.12.0, disposable roots and generated synthetic fixture on C:. See `res644/full-regression.log`. The first isolated full-suite attempt lacked ignored synthetic fixtures and was stopped; it is not a passing qualification run.

Disposition: engineering repair verified by full regression. No new portable/native RES-644 build is claimed; original evidence remains historical. RES-647 will exercise the inherited repaired source through current native/portable workflows. Owner merge authorization remains required. Operational database was read only by existing copy/verification tests. The owner manifest remains untouched, SHA-256 `835398DA594421BC9F04647992B0E9CEFD5DC844FD931D1964896B2E164A2587`.
36 changes: 36 additions & 0 deletions docs/desktop/independent-review/res644/full-regression.log
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
============================= test session starts =============================
platform win32 -- Python 3.12.13, pytest-8.4.2, pluggy-1.6.0
PySide6 6.12.0 -- Qt runtime 6.12.0 -- Qt compiled 6.12.0
rootdir: D:\SWE_HOME\codex_home\worktrees\res644-independent\DynamisScience\services\science
configfile: pyproject.toml
testpaths: tests
plugins: qt-4.5.0
collected 292 items

tests\test_admission.py .................... [ 6%]
tests\test_data_root.py ... [ 7%]
tests\test_data_workspace.py ................... [ 14%]
tests\test_desktop.py .................... [ 21%]
tests\test_extract_movesmart.py ......... [ 24%]
tests\test_formats.py ......... [ 27%]
tests\test_import_review.py ..................... [ 34%]
tests\test_importer.py ...................... [ 42%]
tests\test_integrity_636.py ...... [ 44%]
tests\test_performance.py ............ [ 48%]
tests\test_persistent_workspace.py ......... [ 51%]
tests\test_real_admission.py ...... [ 53%]
tests\test_research_authoring.py ... [ 54%]
tests\test_research_lifecycle.py ................ [ 59%]
tests\test_science.py ...................... [ 67%]
tests\test_sqlite_recovery.py .. [ 68%]
tests\test_storage_isolation.py . [ 68%]
tests\test_storage_isolation_probe.py . [ 68%]
tests\test_traces.py ................ [ 74%]
tests\test_workbench_integration.py ....... [ 76%]
tests\test_workbench_interactive.py ............. [ 81%]
tests\test_workbench_panes.py ................... [ 87%]
tests\test_workbench_results.py .......... [ 91%]
tests\test_workbench_spec.py .................. [ 97%]
tests\test_workbench_theme.py ........ [100%]

======================= 292 passed in 347.60s (0:05:47) =======================
9 changes: 9 additions & 0 deletions docs/desktop/res644-evidence/activity-regression-receipt.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"source_commit": "18494d5eb3afe8831a8c1de6f09c5bac5ec67630",
"command": "uv run pytest",
"platform": "offscreen Qt; native GUI qualified separately",
"passed": 290,
"failed": 0,
"seconds": 360.84,
"log_sha256": "65d4f1c9500f92fbee10604db4a7e82cd5776d0956331081747c67bda122a161"
}
51 changes: 51 additions & 0 deletions docs/desktop/res644-evidence/activity-regression.log
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
........................................................................ [ 24%]
........................................................................ [ 49%]
........................................................................ [ 74%]
........................................................................ [ 99%]
.. [100%]
290 passed in 360.84s (0:06:00)
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-457db5c4-e42d-4308-b85d-45774bc07b7d
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-457db5c4-e42d-4308-b85d-45774bc07b7d'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-3752884a-0931-4da3-96f3-aa16a979d26c
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-3752884a-0931-4da3-96f3-aa16a979d26c'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-7754a1ab-8417-4c0d-a452-c8065cace960
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-7754a1ab-8417-4c0d-a452-c8065cace960'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-1566cf3e-0867-4d00-b3dd-a6e828234fb7\test_folder_import_is_bounded_0\batch
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-1566cf3e-0867-4d00-b3dd-a6e828234fb7\\test_folder_import_is_bounded_0\\batch'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-1566cf3e-0867-4d00-b3dd-a6e828234fb7\test_folder_import_is_bounded_0
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-1566cf3e-0867-4d00-b3dd-a6e828234fb7\\test_folder_import_is_bounded_0'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-1566cf3e-0867-4d00-b3dd-a6e828234fb7
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-1566cf3e-0867-4d00-b3dd-a6e828234fb7'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-66d84a02-86db-4e57-a324-de2fee3d5ee2\test_folder_import_is_bounded_0\batch
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-66d84a02-86db-4e57-a324-de2fee3d5ee2\\test_folder_import_is_bounded_0\\batch'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-66d84a02-86db-4e57-a324-de2fee3d5ee2\test_folder_import_is_bounded_0
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-66d84a02-86db-4e57-a324-de2fee3d5ee2\\test_folder_import_is_bounded_0'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-66d84a02-86db-4e57-a324-de2fee3d5ee2
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-66d84a02-86db-4e57-a324-de2fee3d5ee2'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-bd85dcc3-bed8-46a5-b3fc-6be6b82b773b
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-bd85dcc3-bed8-46a5-b3fc-6be6b82b773b'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-79642364-b868-4e52-b1a3-2eddd0d0f4c3
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-79642364-b868-4e52-b1a3-2eddd0d0f4c3'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-fbc5c6af-12f5-47fe-bcff-4c729ea3680a\test_folder_import_is_bounded_0\batch
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-fbc5c6af-12f5-47fe-bcff-4c729ea3680a\\test_folder_import_is_bounded_0\\batch'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-fbc5c6af-12f5-47fe-bcff-4c729ea3680a\test_folder_import_is_bounded_0
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-fbc5c6af-12f5-47fe-bcff-4c729ea3680a\\test_folder_import_is_bounded_0'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-fbc5c6af-12f5-47fe-bcff-4c729ea3680a
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-fbc5c6af-12f5-47fe-bcff-4c729ea3680a'
warnings.warn(
D:\projects\DynamisScience\services\science\.venv\Lib\site-packages\_pytest\pathlib.py:96: PytestWarning: (rm_rf) error removing \\?\C:\Users\Usuario\AppData\Local\temp\pytest-of-Usuario\garbage-3118aa4b-f0e4-4e62-8e27-b90f6d6151f2
<class 'OSError'>: [WinError 145] The directory is not empty: '\\\\?\\C:\\Users\\Usuario\\AppData\\Local\\temp\\pytest-of-Usuario\\garbage-3118aa4b-f0e4-4e62-8e27-b90f6d6151f2'
warnings.warn(
Loading