Repository navigation
Conversation
…date branch The same app, file for file, with GenHTTP built from the branch at a pinned commit (on ioxide 0.26.563) instead of the GenHTTP 11.3.0 packages, and ioxide.pg and ioxide.timer moved to 0.26.563 to match. The Dockerfile fetches the branch by commit; GENHTTP_COMMIT moves it.
ioxide 0.26.563 refuses to start KernelTx when the tls module can't be put on a socket, and a GitHub runner doesn't always have it: the server stopped at startup, RunAsync logged that to the null logger, and the container exited 0. The entry now probes for the module the way ioxide does and serves userspace TLS without it, so the benchmark host, which has it, still measures kTLS.
Owner
Author
|
/benchmark |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Composite score, main against this run, in the board's default view:
The results on main were measured in another session, so a few points up or down can be the machine and not the change. Full log |
Collaborator
|
/benchmark -f genhttp-ioxide-563 --compare genhttp-ioxide |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Composite score, main against this run, in the board's default view:
The results on main were measured in another session, so a few points up or down can be the machine and not the change. Full log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A copy of
genhttp-ioxide, file for file, that builds GenHTTP from its ioxide-update branch (GenHTTP#953) instead of the GenHTTP 11.3.0 packages on nuget.org.What differs from genhttp-ioxide
Dockerfile: fetches the branch at a pinned commit (GENHTTP_COMMIT, nowa5d6314e), so a later push to the branch doesn't change what this measures. Bump it to follow the branch.genhttp.csproj: project references into that checkout instead of the GenHTTP packages, andioxide.pgandioxide.timerat 0.26.563, the ioxide the branch is on (were 0.15.251).meta.json: the name, and one sentence in the description saying where GenHTTP comes from.Program.cs: kTLS is on only where the kernel's tls module is. ioxide 0.26 refuses to start KernelTx without it, and GitHub's validation runners have it on some VMs only, so the first validation here stopped at startup. The benchmark host has the module, so this still measures kTLS there.Otherwise the app code and the README are unchanged copies.
What the branch changes underneath
Besides ioxide 0.15.251 to 0.26.563:
DisableWriteSynchronizationwould opt out), and a write after the handler ended is refused.Checked locally
sdk:11.0image (SDK 11.0.100): fetch by commit, restore and publish, no warnings.