Skip to content

benchmark-pr: fail and say so on the PR when the results commit can't be pushed - #1816

Merged
MDA2AV merged 1 commit into
mainfrom
benchmark-pr-unsaved-results
Nov 16, 2026
Merged

MDA2AV merged 1 commit into
mainfrom
benchmark-pr-unsaved-results

Conversation

@MDA2AV

@MDA2AV MDA2AV commented Nov 16, 2026

Copy link
Copy Markdown
Owner

When a saved run can't push its results commit, the run now fails and posts a comment on the PR saying why. Before, the push error printed "could not push to fork (permissions)", the step stayed green, and the results were lost without anyone noticing.

That is how #1783 lost its saved run. Commit 533ae33 reached the branch at 18:06 while the run was still measuring f852765, and at 18:13 the results push was rejected as a non-fast-forward. The step passed and nothing reached main, so the board still shows genhttp-ioxide's results from #1749.

The same step saves benchmark, compliance and resilience results, so this covers all three modes. The workflow runs from main's copy of the YAML, so it takes effect once this is merged.

Tested against local git repos with a stub gh: a normal save, the branch moving mid-run, a refused push on this repo and on a fork.

🤖 Generated with Claude Code

… be pushed

A rejected push used to print 'could not push to fork (permissions)' and
leave the step green, so the results were lost without a word. #1783 lost
its saved run that way: a commit reached the branch while the run was
measuring, and the results push was refused as a non-fast-forward.

Now the step fails, and comments on the PR with the reason: the branch
moved (the numbers are for code it no longer has, so they are not rebased
on top either), or the push was refused (a fork without maintainer edits).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant