Repository navigation
Add pgp-sign object for OpenPGP signature packets - #545
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
pgp-signto store an original ASCII-armored OpenPGP signature packet, its binary-packet SHA-256, issuer key IDs/fingerprints, signature metadata, and source key/UID/subkey context. Usepgp-sign --extracted-from--> pgp-key(or another source artifact); an existingpgp-metaobject may also reference the signature withextracted-from.Only
signatureis required. Issuer claims can be absent or conflicting, so issuer fields allow multiple values and explicitly describe their unverified status. UID body hashes preserve exact subject identity when display text is omitted or lossy. All attributes use existing MISP types and default toto_ids=false.Companion expansion: MISP/misp-modules#938.
Validation:
jq -S -jformatting and the module's bundled copy.Local validation used these individual checks; the
validate_all.shwrapper requiresspongeanduuidparse, which are not installed in the workspace.