Repository navigation
Close the parity row 22 fixture gap - #14
Merged
Merged
Conversation
The font fixture is built in memory, so the external validator could never read it. Writes_the_font_fixture_the_external_validator_reads now writes PdfContentFixtures.Fonts() to a stable temp path and pins the fifteen BaseFont names the inspector returns; the pikepdf/qpdf run on that file is recorded in parity row 22 — 17 font objects, 15 unique names, matching the inspector, with the one qpdf repair explained as the fixture's deliberate no-Resources page. Closes #13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/parity.mdrow 22 was Met with one gap: the fixture that pins every branch of the font walk is built in memory, so the externalpikepdf/qpdfvalidator could never read it.PdfFontInspectorTests.Writes_the_font_fixture_the_external_validator_readswritesPdfContentFixtures.Fonts()to%TEMP%/scpdf-fonts-fixture.pdfand pins the 15BaseFontnames the inspector returns./BaseFontnames, exactly the inspector's list.qpdf --checkreports one repairable problem (object 9's page tree child states no/Resources); that is the fixture's deliberate "states no resources at all" shape, now explained in the record.Tests
PdfFontInspectorTests: 21 passed onnet10.0andnet11.0.uv run --with pikepdf --with pypdf python docs/tools/validate-pdf.py <fixture>→ 4 pages, 41 objects, 5 streams decoded, 0 failed; the qpdf repair explained.Closes #13.