Skip to content

Close the parity row 22 fixture gap - #14

Merged
MPCoreDeveloper merged 1 commit into
mainfrom
fix/13-font-fixture-parity
Nov 14, 2026
Merged

MPCoreDeveloper merged 1 commit into
mainfrom
fix/13-font-fixture-parity

Conversation

@MPCoreDeveloper

Copy link
Copy Markdown
Owner

Summary

docs/parity.md row 22 was Met with one gap: the fixture that pins every branch of the font walk is built in memory, so the external pikepdf/qpdf validator could never read it.

  • PdfFontInspectorTests.Writes_the_font_fixture_the_external_validator_reads writes PdfContentFixtures.Fonts() to %TEMP%/scpdf-fonts-fixture.pdf and pins the 15 BaseFont names the inspector returns.
  • The external run on that file is recorded in parity row 22: PDF 1.7, 4 pages, 41 objects, 5 streams decoded, 0 failed; a pikepdf walk listed 17 font objects / 15 unique /BaseFont names, exactly the inspector's list.
  • qpdf --check reports one repairable problem (object 9's page tree child states no /Resources); that is the fixture's deliberate "states no resources at all" shape, now explained in the record.

Tests

  • PdfFontInspectorTests: 21 passed on net10.0 and net11.0.
  • External: uv run --with pikepdf --with pypdf python docs/tools/validate-pdf.py <fixture> → 4 pages, 41 objects, 5 streams decoded, 0 failed; the qpdf repair explained.
  • Pikepdf font walk: 17 objects, 15 unique names, matching the inspector.

Closes #13.

The font fixture is built in memory, so the external validator could never read it. Writes_the_font_fixture_the_external_validator_reads now writes PdfContentFixtures.Fonts() to a stable temp path and pins the fifteen BaseFont names the inspector returns; the pikepdf/qpdf run on that file is recorded in parity row 22 — 17 font objects, 15 unique names, matching the inspector, with the one qpdf repair explained as the fixture's deliberate no-Resources page.

Closes #13.
@MPCoreDeveloper
MPCoreDeveloper merged commit b7591dc into main Nov 14, 2026
5 checks passed
@MPCoreDeveloper
MPCoreDeveloper deleted the fix/13-font-fixture-parity branch November 14, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Write the font fixture to disk for the external validator run (parity row 22)

1 participant