Repository navigation
Add one-call diagnostics (P4) - #15
Merged
Merged
Conversation
IPdfDiagnoser.DiagnoseAsync returns a PdfDiagnosticsReport — the document, its fonts, its signatures, an optional PDF/A pre-flight and the merged, de-duplicated warnings — assembled from the use cases the library already exposes. A document that stays closed is reported with IsReadable/RequiresPassword and read once, not thrown; the report never returns stream contents. The tools/SharpCorePDF.Diagnostics console prints it as text or JSON. Twenty-two domain and three application snapshot entries; nine tests; the manual's chapter 8 gains the section and the 1.7.0 edition is rebuilt at 125 pages. The scoped Stryker run is 42.86% over the service, with each survivor explained in docs/mutation-testing.md. Closes #11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IPdfDiagnoser.DiagnoseAsyncreturns aPdfDiagnosticsReport— the document, its fonts, its signatures, an optional PDF/A pre-flight and the merged, de-duplicated warnings — assembled from the use cases the library already exposes, so it cannot disagree with them.IPdfDiagnoser(Domain port) +PdfDiagnoserService(Application), depending onIPdfInspector,IPdfFontInspector,IPdfSignatureValidatorandIPdfAWriter.IPdfInspectorgains nothing.IsReadable/RequiresPasswordand read once; the other use cases are skipped.Archivalisnullunless a profile is named; when it is, the writer's own pre-flight fills it, withStream.Nullas the destination.tools/SharpCorePDF.Diagnosticsprints the report as text or JSON (--profile,--json).Tests
PdfDiagnoserTests: clean document, rebuilt cross-reference finding, encrypted without throwing, archival pre-flight, undefined profile, font-warning merge, one open for a closed document, null source, container resolution.net10.0andnet11.0.PdfDiagnoserService.cs: 42.86% after the first run's survivors were read and the two real gaps closed; the remaining survivors are theConfigureAwaitarguments, a message string, the redundant null guard and two merge statements whose fixtures cannot tell them apart — all recorded indocs/mutation-testing.md.check: ok,qpdf check: no problems.Closes #11.