Repository navigation
Ship symbols and prove the packages reproducible (G4) - #16
Merged
Merged
Conversation
Every dotnet pack now writes a .snupkg beside the .nupkg, publish.yml checks that count and pushes the symbols to nuget.org's symbol server, and a reproducible CI job packs the same commit twice and compares every entry of every package. The assembly and file versions follow <Version> again; the 1.7.0 bump had left them at 1.6.0.0. The reproducible script was run locally: 5 packages, 5 symbol packages, every entry identical. Closes #12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the last release gate that was only partly met (
docs/release-checklist.mdG4).src/Directory.Build.propssetsIncludeSymbolsandSymbolPackageFormat=snupkg, so everydotnet packwrites a.snupkgbeside each.nupkg.publish.ymlchecks the count and pushes the symbols to nuget.org's symbol server (/api/v2/symbolpackage).docs/tools/verify-reproducible.ps1packs the solution twice withContinuousIntegrationBuild=trueand compares every entry of every package (the container records timestamps, so a file hash would be a weaker check). A newreproduciblejob inci.ymlruns it on every push and pull request.AssemblyVersion/FileVersionfollow<Version>again; the 1.7.0 bump had left them at 1.6.0.0, which also made the default producer string readSharpCorePDF 1.6.0.Evidence
reproducible: 5 package(s), 5 symbol package(s), every entry identical.net10.0andnet11.0.yaml.safe_load).Notes
publish: false) checks the.snupkgcount and stops before any push, as before.Closes #12.