Skip to content

Ship symbols and prove the packages reproducible (G4) - #16

Merged
MPCoreDeveloper merged 1 commit into
mainfrom
feat/12-symbols-reproducible
Nov 14, 2026
Merged

MPCoreDeveloper merged 1 commit into
mainfrom
feat/12-symbols-reproducible

Conversation

@MPCoreDeveloper

Copy link
Copy Markdown
Owner

Summary

Closes the last release gate that was only partly met (docs/release-checklist.md G4).

  • Symbols. src/Directory.Build.props sets IncludeSymbols and SymbolPackageFormat=snupkg, so every dotnet pack writes a .snupkg beside each .nupkg. publish.yml checks the count and pushes the symbols to nuget.org's symbol server (/api/v2/symbolpackage).
  • Reproducible. docs/tools/verify-reproducible.ps1 packs the solution twice with ContinuousIntegrationBuild=true and compares every entry of every package (the container records timestamps, so a file hash would be a weaker check). A new reproducible job in ci.yml runs it on every push and pull request.
  • Version metadata. AssemblyVersion/FileVersion follow <Version> again; the 1.7.0 bump had left them at 1.6.0.0, which also made the default producer string read SharpCorePDF 1.6.0.

Evidence

  • Local run: reproducible: 5 package(s), 5 symbol package(s), every entry identical.
  • Full suite: 1195 passed / 0 failed / 0 skipped on net10.0 and net11.0.
  • Both workflows parse (yaml.safe_load).

Notes

  • The symbol push uses the same temporary OIDC key as the package push; a dry run (publish: false) checks the .snupkg count and stops before any push, as before.
  • Code signing remains out of scope; G4 treats it as "as appropriate".

Closes #12.

Every dotnet pack now writes a .snupkg beside the .nupkg, publish.yml checks that count and pushes the symbols to nuget.org's symbol server, and a reproducible CI job packs the same commit twice and compares every entry of every package. The assembly and file versions follow <Version> again; the 1.7.0 bump had left them at 1.6.0.0.

The reproducible script was run locally: 5 packages, 5 symbol packages, every entry identical.

Closes #12.
@MPCoreDeveloper
MPCoreDeveloper merged commit e6c9e09 into main Nov 14, 2026
6 checks passed
@MPCoreDeveloper
MPCoreDeveloper deleted the feat/12-symbols-reproducible branch November 14, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Pack symbols and prove a reproducible build (release gate G4)

1 participant