Repository navigation
Prepare 1.8.0, add CodeQL, and close the canvas mutation survivors - #19
Merged
Merged
Conversation
The [Unreleased] batch that landed since 1.7.0 is cut as 1.8.0: Version and the assembly and file versions move to 1.8.0, CHANGELOG holds the entry, PackageReleaseNotes (which still said 1.6.0) carries the same summary, the public API moves from Unshipped to Shipped (23 Domain and 3 Application entries), and the manual is rebuilt as the 1.8.0 edition (27 chapters, 125 pages, 236 bookmarks). The tag and the push are the owner step. Two warnings the build had grown are fixed: the diagnostics tests pass TestContext.Current.CancellationToken (xUnit1051, seven warnings) and the diagnostics tool caches one JsonSerializerOptions (CA1869), so dotnet build -c Release is 0 warnings and 0 errors again. The tool also accepts --profile 4, which PDF/A-4 made reachable. CodeQL is added (.github/workflows/codeql.yml): the C# extractor over the real Release build, security-extended, on push, pull request and weekly, with SARIF in the Security tab. The foundation-readiness record is refreshed to 2026-11-14 and the release checklist gains the 1.8.0 gate section. The mutation survivors in PdfPageCanvas.cs are closed: 42.04% to 85.99%, 67 to 13. The new PdfPageCanvasTests asserts the operations the canvas records - the guards, the four cubic curves point by point, and the state counter - and docs/mutation-testing.md reads each of the thirteen that remain. The suite is 1229 on each leg.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four things, in one change because they meet at the 1.8.0 cut.
1. The 1.8.0 release is prepared
<Version>,AssemblyVersionandFileVersionmove to 1.8.0;CHANGELOG.mdholds## [1.8.0] - 2026-11-14andPackageReleaseNotes(which still said 1.6.0) carries the same summary.UnshippedtoShipped: 23 Domain entries (IPdfDiagnoser,PdfDiagnosticsReport,PdfAProfile.PdfA4) and 3 Application entries (PdfDiagnoserService).PublicAPI.Unshipped.txtis back to#nullable enable, andRS0016/RS0017stay build errors.check: ok. The preface and the two READMEs say 1.8.0.docs/release-checklist.mdgains theG1–G9 at 1.8.0section and says which gates are checked (G1–G4, G9) and which are not yet (G6–G8).2. Two warnings the build had grown are fixed
PdfDiagnoserTestspassesTestContext.Current.CancellationToken(xUnit1051, 7 warnings).tools/SharpCorePDF.Diagnosticscaches oneJsonSerializerOptions(CA1869) and accepts--profile 4, which PDF/A-4 made reachable.dotnet build -c Releaseis 0 warnings, 0 errors again.3. CodeQL
.github/workflows/codeql.ymlruns the C# extractor over the real Release build (both target frameworks),security-extended, on push, pull request and weekly, and uploads SARIF to the Security tab. The actions are pinned by SHA like every other workflow. This is the half of the foundation-readiness “Dependabot or CodeQL” item a file can supply;docs/foundation-readiness.mdis refreshed to 2026-11-14 (107 commits, 5 issues, 13 PRs, 9 tags).4. The canvas mutation survivors are closed
Scoped Stryker run over
PdfPageCanvas.cs:PdfPageCanvasTestsadds 33 cases that assert the operations the canvas records rather than the content stream they become: the null/NaN/zero/negative guards, the four cubic curves of an ellipse point by point, and theSaveState/RestoreStatecounter.docs/mutation-testing.mdreads each of the 13 that remain (8 are exception-message strings, 3 are constructor guardsdefault(PdfPageSize)cannot distinguish, 1 is an unreachableValidatePosition, 1 is the run offset of a left-aligned layout).Evidence
dotnet build .\SharpCorePDF.slnx -c Release→ 0 warnings, 0 errors.dotnet test→ 1229 passed, 0 failed onnet10.0and onnet11.0.dotnet run --project tools\SharpCorePDF.Manual→ 27 chapters, 125 pages, 236 bookmarks,check: ok.--solution SharpCorePDF.slnx --mutate "**/PdfPageCanvas.cs"→ 85.99%.Note
No
src/production code changed: the canvas hardening is tests only, and the 1.8.0 diff is version metadata plus the API snapshot. The Stryker run over the touched production file is the canvas run above.