Skip to content

test(items): update the item count of the default stat profile - #1528

Merged
sven-n merged 1 commit into
MUnique:masterfrom
icheat2win:fix/item-profile-count
Nov 16, 2026
Merged

sven-n merged 1 commit into
MUnique:masterfrom
icheat2win:fix/item-profile-count

Conversation

@icheat2win

Copy link
Copy Markdown
Contributor

The Talisman of Resurrection (#1461) and the Lucky Coin (#1464) each raised the expected count of the default profile from 243 to 244. Both were merged, so the count is 246 now, and the test failed on master.

Claude-Session: https://claude.ai/code/session_011xNc75fJTee8EPxDxQxuGi

The Talisman of Resurrection (MUnique#1461) and the Lucky Coin (MUnique#1464) each
raised the expected count of the default profile from 243 to 244. Both
were merged, so the count is 246 now, and the test failed on master.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_011xNc75fJTee8EPxDxQxuGi
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T06:35:56.278989Z 6b17493 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sven-n sven-n left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I verified the number on master's history: the count is 245 right after #1464 (Lucky Coin) and 246 after #1461 (Talisman of Resurrection). Each of them updated it only on its own branch. With this change, all ItemStatProfilesDataTest tests pass locally.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants