Repository navigation
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 1 minor |
🟢 Metrics 53 complexity · 42 duplication
Metric Results Complexity 53 Duplication 42
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…gredient In a configuration whose data of 13/50 and 13/51 is only partly swapped, which the update leaves as it is, the ticket has the name of the covenant. The combination took it as the covenant and gave the same ticket back, and lost it when it failed.
…ple which isn't available
…when the temple has no ticket
…ve them their original names already The update recognized the swapped data only by the names. A server owner who renamed both items back kept the ticket at 1x2 and the drops on the ticket, and the update left it so. Now the swapped sizes with the original names count as swapped, too, and the update restores the rest of the data, keeping the names.
…panel come from the plug-in resources, in English, German and Chinese
… plug-in resources also on the updates page The display attribute used the resources, but the Name and Description properties, which the updates page of the admin panel shows, still returned the English constants, and the text was kept twice.
…es the items instead of throwing The check for the ticket as an ingredient looked up the result item when the items were checked, which happens for every item put into the chaos machine. Without an item of the result name, e.g. renamed by the server owner, it threw there instead of only when mixing.
…giving the items their original names When the names are swapped, a store item of 13/51 is named the covenant, so it moves to 13/50. When the owner gave the items their original names already, a store item of 13/51 which the owner added may be meant as the Scroll of Blood, so only the items of Lumen the Barmaid, who sells the covenant, move.
…age like the monster names
…ts ingredients The result can be bigger than an ingredient, like the 2x2 Scroll of Blood or Invisibility Cloak. Other items in the chaos machine could take the place which it needs after the ingredients are removed; then the mix succeeded, but the created ticket was in no storage. With the three ingredients alone, there's always a place for it.
… for the ingredient check
…h version 3 get the restoration of renamed-back items
…on 3, which the data update service applies again
…m groups move to 13/50
…, but still gives the ticket of an inactive one
… its result is bigger than each ingredient
…, like the ticket check of the temple entry
…op item groups of the renamed-back case
…tems in one method each
…o when the owner fixed the sizes
…the renamed-back case
…ticket finds no place
…hout a ticket item
…the swap are left
Mosch0512
force-pushed
the
fix/illusion-temple-ticket-review-fixes
branch
from
November 17, 2026 22:39
e2bffe1 to
d541792
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #1473. Its review fixes were committed after the head which got merged, so they're not on master yet. They fix the ticket crafting and the update of #1473.
What
IllusionTempleTicketCrafting,BaseEventTicketCrafting):Equals, like the ticket check of the temple entry). Otherwise, a ticket which has the name of an ingredient, like in a partly swapped configuration, would be taken and given back, or lost when the mix fails.BaseEventTicketCraftingis shared, so this applies to the Blood Castle mix too (2x2 Invisibility Cloak from 1x2 ingredients): with a full chaos machine it now answersIncorrectBloodCastleItems, where it ran before. With room left, other items are accepted as before. The place is checked by the newIStorage.FitsAfterRemoval, which uses the placement ofStorage. The Devil Square mix is unchanged: its 1x1 Devil's Invitation always finds a place where an ingredient was.IllusionTempleDataUpdatePlugIn), now version 4, so databases which have version 3 get the new restoration:PlugInResources, in English, German and Chinese, in the admin panel and on the updates page.Testing
dotnet buildoftests/MUnique.OpenMU.Persistence.Initialization.Testsandtests/MUnique.OpenMU.Testswith-p:ci=true.dotnet test --no-build -p:ci=true:MUnique.OpenMU.Persistence.Initialization.Tests: 928 passed, 0 failed, 12 skipped (the database/manual ones)MUnique.OpenMU.Tests: 3207 passed, 0 failed, 2 skippedIllusionTempleTicketCraftingTest: the crafting gives the ticket of an inactive temple which is the only one of its level, prefers the ticket of an available temple, and gives the Scroll of Blood without a ticket of the temple; a ticket with the name of the covenant is refused; an event ticket crafting without its result item refuses instead of throwing; other items in the chaos machine (an unrelated one or a second ingredient) are accepted while the result finds a place, and refused by the Illusion Temple and Blood Castle craftings when they leave it none; the Devil Square crafting accepts them; the Scroll of Blood is placed where the ingredients were, after they're removed like the combination does.IllusionTempleTicketItemsTest: a configuration with swapped names, whose sizes the owner fixed already, gets the original sizes (also when applied twice); a configuration with the original names but swapped data is restored and keeps the names (all three swapped states of fix(illusion-temple): make the Scroll of Blood (13/51) the ticket again and give 13/50 back to the Illusion Sorcerer Covenant #1473, from installed version 2 and 3, which the data update service applies again); with the original names and sizes, Lumen's store items, the covenant groups and the temple tickets are repaired; a Scroll of Blood which the owner added to another store stays, and so do a drop item group of the owner with 13/51 and a covenant group which the owner already pointed at 13/50; on a configuration with the original data, the owner's sizes and a temple ticket set to 13/50 stay.IllusionTempleDataTest: a configuration with the original data stays unchanged also from installed version 3.LocalizedUpdatePlugInNameTest: the name and description of the update are localized.