Repository navigation
feat(weather): add Bright Sky provider - #4306
Merged
Merged
Conversation
khassel
pushed a commit
that referenced
this pull request
Oct 13, 2026
The e2e test "calendar with secrets" fails in #4306 (expected 8, received 6). The test used a public holiday calendar. Since October 12, that calendar only has 3 upcoming events instead of 4, so the count is wrong. With this change the test uses a local mock calendar with an endless daily event. This always gives 10 events per calendar, so the expected count is 20.
Adds a server-side provider for Bright Sky (https://brightsky.dev), a free JSON API for the open data of the German Meteorological Service (DWD). It needs no API key and gives very good results for Germany, which so far has no dedicated provider. - current: latest station observation (/current_weather) - hourly: MOSMIX forecast records (/weather) - forecast/daily: hourly records aggregated into local calendar days. Bright Sky records describe the previous hour, so the 00:00 record counts towards the previous day. Today keeps its already elapsed hours, so min/max and precipitation cover the whole day and today does not disappear late in the evening. Builds on the WeatherProvider base class, uses the shared provider utilities (SunCalc sun times, km/h -> m/s) and requests the date range via urlFactory, so it stays current across midnight.
KristjanESPERANTO
force-pushed
the
brightsky
branch
from
October 14, 2026 06:34
e4a712a to
7e10866
Compare
khassel
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, the original PR #4291 was closed, so I picked up its first commit and gave it a bit of polish.
Bright Sky is a really cool project: it makes weather data from the German Weather Service available through an open API, with no API key needed.
A big thank-you to @ms-zone-41 for the original implementation! 😃