Repository navigation
Stabilize Agent session-isolation test on shared CI runners - #1083
Merged
Merged
Conversation
AnthonyRonning
marked this pull request as ready for review
October 6, 2026 18:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop Agent session-isolation regression test times out after one second while waiting for an entire prompt to complete, including Goose session/database I/O. Research's version-only 3.4.4 PR hit this deadline on a shared Linux runner:
an unrelated lifecycle holder must not block the first provider poll: Elapsed(()), with the rest of the suite passing.Use a ten-second hang deadline for this test and document its purpose. The unrelated lifecycle mutex remains held until the prompt completes, and provider-call/terminal-message assertions stay intact. A real dependency on that mutex still prevents completion and fails the test. No application behavior or release versions change.
Validation:
git diff --checkpassed.Failure evidence: Rust CI on the version-bump PR. Kept separate from the isolated 3.4.4 bump.