Repository navigation
Agent: unify hover feedback and transitions - #1355
Open
matthewrball wants to merge 4 commits into
Open
matthewrball wants to merge 4 commits into
matthewrball wants to merge 4 commits into
Conversation
matthewrball
marked this pull request as ready for review
October 28, 2026 22:43
Author
|
@marksftw This is ready for your review. The ordinary hover states use neutral gray with subtle 120 ms easing, including the composer expand/shrink control from the latest example in #1354. Local checks: 1,146 app tests passed (two ignored), independent source review is clear, and the native macOS smoke check passed. CI is awaiting maintainer approval. GitHub won’t let this contributor account assign reviewers, so tagging you here. |
matthewrball
marked this pull request as draft
October 28, 2026 23:41
matthewrball
marked this pull request as ready for review
October 29, 2026 00:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Composer controls mix coral and neutral hover backgrounds, and hover changes appear instantly across the app. The attachment button and adjacent Integrations control make the mismatch especially visible.
What this PR adds
Closes #1354. This PR targets master independently of #1347 and #1353; simulated merges with both are clean.
Preview
Reported examples from #1354. Ordinary composer controls now follow the existing neutral Integrations treatment; the expander is included.
Verification
c3cd05eb:agent-lint,agent-test,agent-macos,agent-windows, and requiredci-okall passed.c3cd05eb: 1,148 passed, 0 failed, 2 ignored (cargo test -p maple-agent-app --bin maple-agent --locked -- --test-threads=1).Local validation used Rust 1.96.0 on macOS. The final tests used a private temporary directory and disabled incremental compilation to bound disk use. The pinned CI checks now pass across Linux, macOS, and Windows. No dependency, release, or CI configuration is changed.