Repository navigation
feat: remove by ID only skeleton source - #236
Merged
seankmartin merged 2 commits intoOct 6, 2026
Merged
seankmartin merged 2 commits into
seankmartin merged 2 commits into
Conversation
This skeleton source for catmaid was when we pulled full skeletons and spatial chunks through different sources. Since we unified them it doesn't have much purpose. You can just set the hidden skeletons to be transparent and then they won't fetch and you can pull by ID.
seankmartin
commented
Oct 2, 2026
| const subsources = [ | ||
| { | ||
| id: "skeletons-chunked", | ||
| id: "skeletons", |
Author
There was a problem hiding this comment.
This will change existing states if they listed a change to the sources but I don't expect that to happen. We may want to try merge this into neuroglass before going to prod though, or shortly after. If we agree on removing this source
Member
There was a problem hiding this comment.
I understand. I don't think it's a problem either because it was demo and I agree as well that if we deploy to prod without this change then it becomes a problem
Member
|
I agree with the change. While having codex review the code it mentioned something I though we already fixed but maybe we didn't: |
…te-skeleton-source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This skeleton source for catmaid was when we pulled full skeletons and spatial chunks
through different sources. Since we unified them it doesn't have much purpose. You can
just set the hidden skeletons to be transparent and then they won't fetch and you can
pull by ID.