Skip to content

feat: remove by ID only skeleton source - #236

Merged
seankmartin merged 2 commits into
feature/edit-modefrom
feature/edit-mode-remove-complete-skeleton-source
Oct 6, 2026
Merged

seankmartin merged 2 commits into
feature/edit-modefrom
feature/edit-mode-remove-complete-skeleton-source

Conversation

@seankmartin

Copy link
Copy Markdown

This skeleton source for catmaid was when we pulled full skeletons and spatial chunks
through different sources. Since we unified them it doesn't have much purpose. You can
just set the hidden skeletons to be transparent and then they won't fetch and you can
pull by ID.

This skeleton source for catmaid was when we pulled full skeletons and spatial chunks
through different sources. Since we unified them it doesn't have much purpose. You can
just set the hidden skeletons to be transparent and then they won't fetch and you can
pull by ID.
const subsources = [
{
id: "skeletons-chunked",
id: "skeletons",

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change existing states if they listed a change to the sources but I don't expect that to happen. We may want to try merge this into neuroglass before going to prod though, or shortly after. If we agree on removing this source

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. I don't think it's a problem either because it was demo and I agree as well that if we deploy to prod without this change then it becomes a problem

@afonsobspinto

Copy link
Copy Markdown
Member

I agree with the change. While having codex review the code it mentioned something I though we already fixed but maybe we didn't:

This is unchanged code, but it matters when removing the alternative source. With visible opacity 1 and hidden opacity 0:
- The backend stops requesting spatial chunks.
- areVisibleChunksReady() still requires those chunks to reach GPU memory.
On a fresh view—or after moving into an uncached region—the layer can therefore remain unready even after the selected skeleton loads. [Readiness check](https://github.com/MetaCell/neuroglancer/blob/26c42415ed90efb62bad45f640c13a7b0aef148f/src/skeleton/frontend.ts#L3018)
This affects screenshot capture: normal capture waits for viewer.isReady(), although the UI has a timeout-based forced-capture fallback. [Screenshot readiness gate](https://github.com/MetaCell/neuroglancer/blob/26c42415ed90efb62bad45f640c13a7b0aef148f/src/python_integration/screenshots.ts#L179)
Suggested fix: make readiness follow the rendered passes—skip spatial-chunk requirements when hidden opacity is zero, and account for selected skeletons’ full-data loading.

@seankmartin
seankmartin merged commit fc0a077 into feature/edit-mode Oct 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants