Repository navigation
fix: shader code hiding - #238
Closed
seankmartin wants to merge 1 commit into
Closed
seankmartin wants to merge 1 commit into
seankmartin wants to merge 1 commit into
Conversation
Previously the matching had a few issues. Firstly, because we often prepend invlerp style controls with things like uLerpParams_u or uTransferFunctionEnd_u, the exact prefix match couldn't pick up these uniforms. In addition the prefix based matching could match u_shaderControl_c against u_shaderControl_ca. Also fixes a problem that stems from the volume rendering shader and image shader both in use. The linked shader could bounce between two, repeatedly reporting different hidden controls each frame. Now, all the shaders that are linked are considered together in a set and the union of active controls are shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the matching had a few issues. Firstly, because we often prepend invlerp
style controls with things like uLerpParams_u or uTransferFunctionEnd_u, the exact
prefix match couldn't pick up these uniforms.
In addition the prefix based matching could match u_shaderControl_c against
u_shaderControl_ca.
Also fixes a problem that stems from the volume rendering shader and image shader both
in use. The linked shader could bounce between two, repeatedly reporting different
hidden controls each frame. Now, all the shaders that are linked are considered together
in a set and the union of active controls are shown.