Repository navigation
workflow-console: address the review suggestions on #64 - #74
Open
stevenjj33 wants to merge 1 commit into
Open
stevenjj33 wants to merge 1 commit into
stevenjj33 wants to merge 1 commit into
Conversation
Three follow-ups, one per suggestion. Drop the restatement of the Host's Git-import rule from both READMEs. The rule belongs to the Host and can change under us; a README that repeats it goes stale, and this package does not need to carry it. What the Skill is for — telling the Agent how to drive the console — stays. Say which database "the run record stays in" means: the bundled engine's own `workflows.sqlite` under `context.dataDir/engine/`, in both READMEs and in SKILL.md, so it cannot be mistaken for some other store. Add a `test` script to package.json, so `npm test` in this directory runs the suite instead of reporting a missing script. The command matches the one other plugin in this repository that ships a test script (`node --test "tests/*.test.mjs"`), and the READMEs now lead with it.
Contributor
Author
|
@MyPrototypeWhat 这条 PR 是 #64 评审里三条可选建议的逐条处理,麻烦复审一下,当前 head 是
改动 4 个文件、+17 / −10,全是文档与 验证: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
#64 已合并(
62773d1),评审在bd0d99e上给出 APPROVED,并留了三条可选建议。这个 PR 逐条处理。三条建议
一、README 两个语言版本的 Skill 一节里,关于 Git 导入接受条件的那句话,改动本包以外的规则,规则一变 README 就会过时 —— 建议删掉或中性化。
已按建议删除。宿主「从 Git 仓库导入」的接受条件属于宿主行为,不该由本包的 README 复述,
规则变了 README 就会成为噪音。Skill 本身的价值不受影响——它本来就是给 Agent 说明怎么操作控制台的,
那部分说明全部保留。删掉的理由留在这个 PR 的讨论与提交记录里,不留在 README 里。
二、「数据与边界」里的「运行记录还在引擎数据库里」,可以顺带说明指的是本插件
context.dataDir/engine/下的数据,避免被理解成别的数据库。已在三处补明:
README.md—— the bundled engine's own database —workflows.sqliteundercontext.dataDir/engine/README.zh-CN.md—— 内置引擎自己的数据库里(context.dataDir/engine/下的workflows.sqlite)skills/workflow-console/SKILL.md—— 同一句措辞三、插件
package.json没有 test 脚本,在插件目录执行npm test会报 Missing script。已加上,并按本仓库另一个带测试脚本的插件(
plugins/zch0227/disk-insight)的写法:两份 README 的测试章节也改成以
npm test开头,并说明它等价于node --test "tests/*.test.mjs"。验证
npm test(在插件目录):16/16 通过;npm run check(仓库根):69/69,0 errors;canImport: true(与 workflow-console 1.2.0: ship a Skill so the plugin can be imported from Git #64 合并前一致)。改动共 4 个文件、+17 / −10,全部是文档与
package.json,无代码与运行时行为变化。Need help on this PR? Tag
@codesmith-botwith what you need.