Repository navigation
Fix the E5 review findings - #853
Merged
Merged
Conversation
Keep the events bound at 64 per request and 512 KiB of stored input and record the gap: the input reservation check, request deadlines and the Claude Code per-Turn message list do not hold larger batches. Record the Claude Code 64-message Turn limit and the MiniMax Code instructions limit, name Codex for apply_patch, state why request_metadata is rejected, note the Subagent function_call exception on the stream, restore the typed packages.system error for a non-array value and test both Turn IDs answering a Subagent call.
MaxInputBatch is the one definition of the 64-event bound, and a test reserves a full batch on an Environment Session so the validator and the reservation check cannot drift apart. The events bound moves beside its peer differences, the Claude Code limit links its owning rule, the request_metadata message matches the documented reason, packages.system docs name every rejected value, and the stream rules drop a child snapshot sentence that no event produces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the findings of the batched review over #850–#852.
environment_input_reservations_batch_checkallows 64), at the request deadlines (one 16384-event transaction measured 160 s against the 30 s write timeout and 5 s reservation context) and in the Claude Code adapter (64 messages per Turn). The bound returns to 64 events and 512 KiB, and the compatibility doc records the gap.instructionslimit (OpenAI compatibility, Harness capabilities).apply_patchfunction calls, says whyrequest_metadatais rejected, and notes the Subagentfunction_callexception in the stream rules.packages.systemreturns the typedpackages.systemerror again.Checks:
go vet ./...(services/core),go test ./internal/api -run 'TestSystemPackages|Input|Event',./internal/sessions -run Input, the Subagent function call integration tests, zh hashes refreshed.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.