Repository navigation
Added ability to tweak the rotation and offset of individual model parts for entity being displayed by entity display block - #152
Merged
Conversation
HyperPigeon
commented
Oct 10, 2026
HyperPigeon
commented
…rts for entity being displayed by entity display block
HyperPigeon
requested review from
Ampflower,
Awakened-Redstone and
Tomate0613
October 10, 2026 23:16
Tomate0613
reviewed
Oct 12, 2026
…ity display block - recurse into child parts - updated getModelRoot to take entity instead of entity type as parameter
Author
|
Author
Use Vec3 widget for model part rotation and offset
|
Ampflower
requested changes
Oct 15, 2026
Ampflower
left a comment
Ampflower
left a comment
Member
There was a problem hiding this comment.
These should really not be using opaque integer enums.
This could be frankly better, but, it's fine. Has scaffolding to handle X scrolling as well as Y. Future considerations is to add a scrollbar when it is scrollable.
Ampflower
approved these changes
Oct 15, 2026
Ampflower
left a comment
Ampflower
left a comment
Member
There was a problem hiding this comment.
Nothing that I can really note left.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.