Repository navigation
feat: exact component match on item acceptors - #154
Merged
Merged
Conversation
Ampflower
requested changes
Oct 17, 2026
Ampflower
left a comment
Ampflower
left a comment
Member
There was a problem hiding this comment.
/clear-esk predicates aren't strictly required, but I noticed one issue that namespace:invalid_item[component="b"] would not be treated the same as namespace:invalid_item.
Ideally, if Minecraft can reasonably parse it normally, it is valid, even if the item or requested components does not currently exist.
Comment on lines
+107
to
+115
| if (!Identifier.isValidPath(item)) { | ||
| return ItemStack.isSameItemSameComponents(stack, getDisplayItemStack()) && stack.getCount() >= count; | ||
| } else { | ||
| Identifier parse = Identifier.parse(item); | ||
| boolean isEqual = isItemTag | ||
| ? stack.is(TagKey.create(Registries.ITEM, parse)) | ||
| : stack.is(BuiltInRegistries.ITEM.getValue(parse)); | ||
| return isEqual && stack.getCount() >= count; | ||
| } |
Member
There was a problem hiding this comment.
This, might be better as a hotswapped cached Predicate?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible for item acceptors to make exact component matches on the item stacks they accept. I opted to make the format for this the same as
/give, relying on Minecraft's existing parsers for components. This meant switching the backingIdentifierout for aString, asIdentifierhas strict restrictions on allowed characters that prevent even simple components from functioning.Testing steps:
/give @s minecraft:birch_planks[minecraft:item_model="diamond_sword"]birch_planksminecraft:birch_planks[minecraft:item_model="diamond_sword"]Fixes #89