Skip to content

Add macros for the fitted model indexed by the input value - #176

Merged
d-morrison merged 6 commits into
mainfrom
claude/indexed-fit-notation-c1ufyg
Oct 16, 2026
Merged

d-morrison merged 6 commits into
mainfrom
claude/indexed-fit-notation-c1ufyg

Conversation

@d-morrison

@d-morrison d-morrison commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Requested by Ezra · project thread

Before: a fitted model evaluated at an input had one form, the function applied to x (\emodmemf{x}, h-hat(x)), and \emodmemof{D} put a data set in the subscript. The average fit \avgfit printed h-bar, the bar that we also use for sample means.

After (Ezra, 2026-10-16):

  • \emodmemat{x} prints h-hat with subscript x, and \emodmematf{x}{D} prints h-hat_x(D): the input is the subscript and the data set is in parentheses, to show that the randomness comes from the data set and x is a continuous index.
  • \avgfit now prints \popmean_{\modmem}, μ_h, and \avgfitf{x} prints μ_h(x). It is the population mean over data sets of the indexed fit, a fixed function that nothing estimates, so it has no bar and no hat. The notes define it once as the expectation and then use the shorthand.

The indexed form is for derivations that average over data sets. Everywhere else the fitted function applied to x stays, as in ISL and ESL. \avgfit and \avgfitf keep their names, so uses in other repos change from h-bar to μ_h at the next pin bump.

How: macros.qmd and interpretations.tsv; main is merged in (it carries #175). A separate Claude agent reviewed the definitions before the \popmean change and found them clean; no human or bot review job has run on this PR.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DtHcRxruk5oMMZ7L45fytp

Copilot AI balanced review requested due to automatic review settings October 16, 2026 17:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@d-morrison d-morrison self-assigned this Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

The check job failed before any of this PR's content was built. quarto install tool tinytex got a 403 from GitHub when it asked for the latest rstudio/tinytex-releases release (job log). That is not caused by this PR's two macro definitions. I re-ran the failed job once.


Generated by Claude Code

Copilot AI balanced review requested due to automatic review settings October 16, 2026 17:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI balanced review requested due to automatic review settings October 16, 2026 17:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI balanced review requested due to automatic review settings October 16, 2026 17:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Comment thread macros.qmd Outdated
Copilot AI balanced review requested due to automatic review settings October 16, 2026 18:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-16 18:13 UTC

Copy link
Copy Markdown
Collaborator Author

Separate-agent Claude review of head abb4e4c7e125a1df2c3f5793d7a22e98c3a53489 found no defects: syntax, dependencies (\popmean, \modmem, \est, \paren), name collisions, and a well-formed interpretations.tsv with the merged \etargetfn rows intact. Only Claude reviewed this PR; no non-Claude reviewer was available (OpenCode Go weekly limit). All five CI checks pass on this head. Merging on Ezra's /mwc 176 and his earlier "yes" that a separate-agent Claude review counts for macros.


Posted by Claude Code (AI agent) --- not written by a human.
Generated by Claude Code


Generated by Claude Code

@d-morrison
d-morrison merged commit 9e646e9 into main Oct 16, 2026
5 of 6 checks passed
@d-morrison
d-morrison deleted the claude/indexed-fit-notation-c1ufyg branch October 16, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants