Skip to content

Check the lms/ link again now that lms is on main - #37

Merged
dem-extra1 merged 1 commit into
mainfrom
claude/project-thread-sv4gco
Oct 14, 2026
Merged

dem-extra1 merged 1 commit into
mainfrom
claude/project-thread-sv4gco

Conversation

@dem-extra1

Copy link
Copy Markdown
Contributor

Before: lychee.toml skipped https://github.com/Morrison-Lab/psc/tree/main/lms, because that directory did not exist on main until #33 merged.

After: the link check covers that URL again. #33 merged as 3d92ab2, and the URL returns 200.

Closes #36.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Jt6yVGbqCGUgWio5QUBDex


Generated by Claude Code

psc#33 excluded https://github.com/Morrison-Lab/psc/tree/main/lms from
the link check because the directory did not exist on main until that
PR merged. It merged as 3d92ab2, and the URL now returns 200, so the
exclusion goes.

Closes #36

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01Jt6yVGbqCGUgWio5QUBDex
@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


This is exactly what issue #36 asked for. The diff removes precisely the temporary exclusion entry (and its now-stale explanatory comment) added by #33, nothing more. No other changes, no scope creep, no build artifacts touched. The removal doesn't disturb surrounding exclusion entries or formatting.

I checked for a prior Claude comment on this PR — comments: [], so none exists yet; this is the first review.

No CLAUDE.md, lintr, or Quarto-syntax concerns apply here since the only file touched is lychee.toml, a config file, not .qmd/R source. Link-check guidance in CLAUDE.md ("prefer fixing broken links over adding exceptions") is directly satisfied by removing an exception, which is the correct direction.

I don't see any issues with this change.

Verdict

Ready for merge — the change is a minimal, correctly-scoped removal of the stale lms/ exclusion from lychee.toml, verified against main: lms/ exists there (merged as 3d92ab2) and the previously-excluded URL now returns HTTP 200, exactly matching issue #36's request. No CLAUDE.md, Quarto, or R conventions are implicated by this one-line config diff.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "e8be76727005a00642343ccc6d04a19aadf15e3d",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "lychee.toml now drops the temporary lms/ exclusion and I confirmed main already has lms/ merged (3d92ab2) and the tree URL returns HTTP 200, so no broken-link regression is introduced.",
  "holistic_assessment": "Scope matches issue 36 exactly, no unrelated files touched, no new dependencies, and build artifacts remain untouched, so regression risk and integration concerns are minimal."
}

Reviewed commit: e8be767

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2038 (review) — run

Copy link
Copy Markdown
Contributor Author

ARD for the OpenCode (kimi-k3) review on e8be767:

  • Rebut (nothing shows psc#33 has merged). #33 merged at 2026-10-14T19:29:03Z as 3d92ab2. This branch is cut from that commit, and https://github.com/Morrison-Lab/psc/tree/main/lms returns 200 (both checked through the API and curl just now). The PR body states the same.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

Cross-model review (OpenCode Go, kimi-k3) on head e8be767, given the earlier finding and the response above: VERDICT: CLEAN, no findings.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-14 19:39 UTC

@dem-extra1
dem-extra1 merged commit eb29d9b into main Oct 14, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the temporary lms/ link exclusion from lychee.toml

2 participants