Repository navigation
Python: read AverageBoatSpeed at scale 100, and honour a file scale. - #34
Merged
Merged
Conversation
Same units with a different declared scale decode with that scale. A missing scale on this field is the old scale 255, which FIT hides because 255 is the UINT8 invalid value. Co-authored-by: Cursor <[email protected]>
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Collaborator
Author
|
Holding this until the spec PR it implements, #14 (AverageBoatSpeed at scale 100), is settled. #14 has approvals but is still open, with an unresolved discussion about how 🤖 Generated with Claude Code |
Member
|
#14 was merged, we'll discuss at the committee meeting, let's get this merged as well. |
JBlaak
approved these changes
Oct 22, 2026
Keep both the boat-speed scale tests and the workout-state test in test_reader.py. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same units with a different declared scale decode with that scale. A missing scale on this field is the old scale 255, which FIT hides because 255 is the UINT8 invalid value.
Co-authored-by: Cursor [email protected]
Implements the Python side of #14. Should be merged after #14.
The diff against
maincontains only this change.🤖 Generated with Claude Code