Repository navigation
Python: remove stale comment about timestamp units in the spec - #50
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change only removes stale comments, preserves the epoch and units documentation, and has no unresolved findings.
No open issues 🎉
What changed in this PR
Removes obsolete commentary about timestamp units beside the Python FIT epoch constant.
Changes:
- Deletes two stale comment lines while preserving
FIT_EPOCH_UNIXand the documentation that FIT timestamps count seconds. Runtime behavior is unchanged.
| File | Description |
|---|---|
python/src/rowing_data/constants.py |
Removes the outdated note about a draft specification’s timestamp units. |
Review effort: Balanced
JBlaak
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two comment lines in
python/src/rowing_data/constants.pynext toFIT_EPOCH_UNIX. They said the draft spec table gave the nativetimestampin milliseconds. That error was in an old version of the spec and has since been fixed, so the comment no longer applies.Comment-only change, no behaviour change.
🤖 Generated with Claude Code