Skip to content

App: a colour dialog with colours to tap, a hue and saturation picker and a preview - #236

Merged
vadi2 merged 2 commits into
mainfrom
ccr-14671218-tf96z6-colour-picker
Nov 21, 2026
Merged

vadi2 merged 2 commits into
mainfrom
ccr-14671218-tf96z6-colour-picker

Conversation

@vadi2

@vadi2 vadi2 commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Brief overview of PR changes/additions

  • The Settings colour dialog was three RGB sliders and a hex field. It now has:
    • a preview of the colour next to the colour it is seen with
    • colours to tap: the 16 ANSI colours, two greys and the setting's own Mudlet colour
    • a saturation and brightness square, and a hue bar
    • the hex field
    • the RGB sliders, folded under "Fine-tune"
  • TalkBack:
    • Each swatch is one radio-button node, named from strings.xml.
    • The square reads its saturation and brightness, and has custom actions that step either one by 5%.
    • The hue bar works as a slider.
  • The colour maths is in ColourPicking.kt, a pure function with a JVM test.

Motivation for adding to Mudlet

  • Dragging three RGB sliders is a hard way to choose a colour.
  • No built-in picker to use instead:
    • The Android framework API has none.
    • Compose Material 3 1.4.0 (our BOM) has none; its only pickers are for dates and times.
    • Material Components is not a dependency.
  • The new dialog follows desktop Mudlet's own colour dialog (QColorDialog).

Other info (issues closed, discussion etc)

🤖 Generated with Claude Code

https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J

@vadi2
vadi2 force-pushed the ccr-14671218-tf96z6-colour-picker branch from a2d82db to 6461721 Compare November 21, 2026 18:23
… and a preview

The colour dialog in Settings was three RGB sliders and a hex field. Neither
the Android framework nor Compose Material 3 1.4.0 has a colour picker, so
the dialog is the app's own and follows desktop Mudlet's QColorDialog: the
sixteen ANSI colours, two greys and the setting's Mudlet colour to tap; a
saturation and brightness square and a hue bar; the hex field; and the RGB
sliders, folded under "Fine-tune". A preview shows the colour with the one it
is seen with.

TalkBack reads each colour to tap by name with its selected state, steps the
square 5% at a time by custom actions, and moves the hue bar as a slider.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
…do-locale test

The Background row's click action is on the row, not its text, so in the
unmerged tree no node has both and the wait timed out on API 33 and later.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
@vadi2
vadi2 force-pushed the ccr-14671218-tf96z6-colour-picker branch from 53e521b to 9243b9f Compare November 21, 2026 22:57
@vadi2
vadi2 merged commit 8ea268f into main Nov 21, 2026
21 checks passed
@vadi2
vadi2 deleted the ccr-14671218-tf96z6-colour-picker branch November 21, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants