Repository navigation
App: a colour dialog with colours to tap, a hue and saturation picker and a preview - #236
Merged
Merged
Conversation
vadi2
force-pushed
the
ccr-14671218-tf96z6-colour-picker
branch
from
November 21, 2026 18:23
a2d82db to
6461721
Compare
… and a preview The colour dialog in Settings was three RGB sliders and a hex field. Neither the Android framework nor Compose Material 3 1.4.0 has a colour picker, so the dialog is the app's own and follows desktop Mudlet's QColorDialog: the sixteen ANSI colours, two greys and the setting's Mudlet colour to tap; a saturation and brightness square and a hue bar; the hex field; and the RGB sliders, folded under "Fine-tune". A preview shows the colour with the one it is seen with. TalkBack reads each colour to tap by name with its selected state, steps the square 5% at a time by custom actions, and moves the hue bar as a slider. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
…do-locale test The Background row's click action is on the row, not its text, so in the unmerged tree no node has both and the wait timed out on API 33 and later. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
vadi2
force-pushed
the
ccr-14671218-tf96z6-colour-picker
branch
from
November 21, 2026 22:57
53e521b to
9243b9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
strings.xml.ColourPicking.kt, a pure function with a JVM test.Motivation for adding to Mudlet
Other info (issues closed, discussion etc)
libmudletand a Qt front-end Mudlet#9011ccr-14671218-tf96z6-colour-picker-bite(8 mutations ofColourDialog.kt). Each test went red for its own mutation on API 28 and API 36. The pseudo-locale tests run only on API 36, and they caught the summary cut to one line and the hue bar not mirrored in ar-XB.🤖 Generated with Claude Code
https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J