Repository navigation
Move Windows launcher signing to SignPath (supersedes #70) - #73
Merged
Merged
Conversation
The launchers are now staged into one artifact by prepare-signing-win.sh, signed by SignPath in a single request covering the whole GameList, and picked back up by deploy-win.sh, which fails if signing was enabled but a launcher came back unsigned. Drops jsign and the Azure login steps. Co-Authored-By: Claude Opus 5.5 <[email protected]>
- Allow the launcher wildcard to match every game. SignPath wildcards match exactly one file unless max-matches says otherwise, so 44 launchers would have failed every signing request. - Extract signed launchers into a fresh signed-launchers/ directory. The action extracts over its output directory without clearing it, so using the staging directory let the unsigned copies pass the missing-launcher check in deploy-win.sh. - Verify every launcher's Authenticode signature after signing, since SignPath passes uncovered files through unsigned. - Fail builds that should be signed when the SignPath secrets are missing, instead of publishing unsigned launchers, as the Azure step did before. - Grant actions: read, which the SignPath action's token needs to read job details and download the artifact; drop the unused id-token. - Pick up Windows launchers from the MudletInstaller-CLANG64 artifact in organize-launchers.sh. Releases cut for new games without a tag only reach that fallback, which matched MINGW64 or Windows, so they shipped no Windows launchers. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_013FrhV64D6WvcALMeDsT8cb
4 tasks
…releasable builds deploy-win.sh didn't check the copy of the signed launcher over the unsigned one, so a failed copy published the unsigned launcher with CI green. The comment justifying signing every non-PR build said they can all end up in a release, but only tags and development can. Sign just those, so master pushes no longer spend production signing requests. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_013FrhV64D6WvcALMeDsT8cb
…omments - prepare-signing-win.sh exits 7 if a launcher can't be renamed or staged, instead of leaving it to deploy-win.sh three steps later. - The release job only downloads the MudletInstaller-* artifacts, so the unsigned-launchers artifact can never be organized into a release. - Let a re-run of a failed signing job upload its artifact again. - Comments: SignPath, not the action, uses the token; the verify step fails test-signing builds; drop an unverified claim about SignPath passing uncovered files through. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_013FrhV64D6WvcALMeDsT8cb
Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_013FrhV64D6WvcALMeDsT8cb
Restricting signing to tags and development left no way to try a SignPath change before merging it, which the PR's own checklist relies on. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_013FrhV64D6WvcALMeDsT8cb
Member
Author
|
The macOS job failed on 98ca2c0 (log) because Generated by Claude Code |
… SignPath project
vadi2
enabled auto-merge (squash)
November 13, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #70. This keeps @jmckisson's commit unchanged and rebases it onto
developmentnow that #71 is merged. The commits after it fix the problems from the review on #70, plus what three further review rounds on this PR found.Fixes on top of #70
max-matchessays otherwise (docs). The artifact configuration now usesmax-matches="unbounded".deploy-win.sh's "is it there?" check. It now extracts intosigned-launchers/, whichprepare-signing-win.shremoves beforehand.Get-AuthenticodeSignatureon each launcher that went in. It fails the job if one is missing or its status isn'tValid, rather than trusting the signing request's success.SIGNPATH_API_TOKENis empty. A build that should be signed fails if either SignPath secret is missing, as the Azure login step did, instead of publishing unsigned launchers with green CI.actions: read, which the action'sgithub-tokenis documented to need. Dropsid-token: write, which the action never uses.extracted-games/, soorganize-launchers.shalways falls back to artifact names.*MINGW64*|*Windows*, never matchedMudletInstaller-CLANG64, so it now matches*CLANG64*too.deploy-win.shexits 7 if a signed launcher is missing or can't be copied over its unsigned original.prepare-signing-win.shexits 7 if a launcher can't be staged.MudletInstaller-*artifacts, sounsigned-launcherscan never be organized into a release.check-new-gamesand signs only tags anddevelopmentbuilds that add a game. Manualworkflow_dispatchruns on any branch are still signed, so a SignPath change can be tried before merging - they need approving too. The signing wait is raised to 4 hours to leave an approver time.unsigned-launchersupload usesoverwrite: true, so a re-run of a failed signing job can upload again.MudletInstaller.rc.in, product nameMudletInstaller, version from the release tag asX.Y.Z.0,0.0.0.0for unreleased builds), and thelaunchersconfiguration requires both via aversionparameter the workflow passes.bootstrapSignPath project. The OSS organization can't create projects, so SignPath support created projectbootstrap(repository URLhttps://github.com/Mudlet/bootstrap.git, origin verification onrelease-signing). The workflow signs withproject-slug: 'bootstrap'and the policy files live in.signpath/policies/bootstrap/.Testing
cygpath, with SignPath emulated the way its action works (create the folder if missing, extract over it):UNSIGNED-…with exit 0 here.prepare-signing-win.shexits 7.organize-launchers.shon a mocked release:developmentproduces no*-Windows.exe. This branch produces one per game from the CLANG64 artifact.shellcheck -S warning: clean on all three changed scripts.actionlint: no findings on changed lines. The same 24 are on both base and branch, all on existing lines.Before the first signed release
bootstrapwith repository URLhttps://github.com/Mudlet/bootstrap.git; itsrelease-signingpolicy verifies that origin. A dedicated CI user,bootstrap CI, is the submitter on bothbootstrappolicies, so Mudlet/Mudlet'sCI buildstoken can't sign for bootstrap and vice versalaunchersis added to thebootstrapproject from.signpath/artifact-configuration-launchers.xmlSIGNPATH_API_TOKEN(thebootstrap CIuser's token) andSIGNPATH_ORGANIZATION_IDare addedCOPYING, GPL-2.0-or-later like Mudlet)workflow_dispatchrun produces signed launchers, the "Verify launcher signatures" step passes, and SignPath accepts theproduct-versionmatch (run: all 46 launchers signed byCN=SignPath Foundation, request completed withversion0.0.0.0)MudletInstaller-StickMUD.exefrom the run, on Windows 11: signer SignPath Foundation, sha256, DigiCert timestamp;Get-AuthenticodeSignaturereportsValid, issuer GlobalSign GCC R45 CodeSigning CA 2020; ProductNameMudletInstaller, ProductVersion0.0.0.0)No GitHub policy found at .signpath/policies/bootstrap/release-signing.yml(the v1.3.1 run loggedFound policy file .signpath/policies/bootstrap/release-signing.yml.)Until these are done, ordinary pushes are unaffected and only a release fails.
After merging
AZURE_CREDENTIALSsecret.🤖 Generated with Claude Code
https://claude.ai/code/session_013FrhV64D6WvcALMeDsT8cb