Repository navigation
Update from project-template v0.41.1 to v0.61.2 - #12
Conversation
There was a problem hiding this comment.
🤖 NCode Review at 4ee8185: 11 new findings on the changed lines.
|
Superseded by the review at 3fcbe20. |
…ml SDK, docs and changelog
|
Autopilot: Round 2 on the review of 4ee8185, all 11 threads answered. Fixed in c8bd021 and 3fcbe20: the duplicate Generated by Claude Code |
|
/review |
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at 4ee8185: 15 hunks in 9 files and changes taken back in 5 files, by correctness only. No further findings above nits. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.09 on Amazon Bedrock, 16s, at 3fcbe20. (how to interact) 📋 OutcomesMerged at 3fcbe20: 4 fixed, 7 dismissed, 0 acknowledged, 0 ignored.
|
Summary
Updates the project from project-template v0.41.1 to v0.61.2 with
.template/Update-Project.ps1 -Ref v0.61.2, then applies the template's changes to the project-owned files by hand..template/, agent commands, prompts, skills, instructions,build/ProjectTemplate*.props/globalconfig,BannedSymbols.txt,build/dod.ps1,build/Update-PublicApi.ps1, and so on. New:CONTRIBUTING.md,SECURITY.md,docs/decisions/,nuget.config(restore is limited to nuget.org), and the workflowstemplate-update.yml,copilot-setup-steps.ymlandcode-review-auto-merge.yml. The template'spublish.ymlis deleted: the project publishes from a release with thepublishjob of its ownmain.yml(NuGet API key), and both would fire on every release..editorconfig(file header template, generated-code rule for Migrations, analyzer severities),Directory.Packages.props(BannedApiAnalyzers, Nullable.Extended.Analyzer, PublicApiAnalyzers),.gitignore, and Dependabot cooldown, security groups and no offers of a new .NET SDK major. The build now fails on banned APIs, the null-forgiving operator and unused usings.AGENTS.md(new instruction lines, Definition of Done command,gate: ./build/dod.ps1 -Fast,review-bots,max-review-rounds,prelude, the template's Landing text, real conventions;releasestaysnoneanddraftstaysno, the project's existing choices),README.md(Project and License sections),CONTRIBUTING.mdandSECURITY.md(pointing at what the project really does),.github/workflows/code-review.yml.564bb16f8f4f25f88dcc47baae10d7edf55ca504) incode-review.yml, with the review job'sconcurrency.groupline from that release's caller, so a/reviewcomment followed by more lines, such as an agent's---footer, reviews the pull request instead of cancelling the review in progress. The 3-day dependency cooldown is not met (v1.1.2 was published on 2026-11-02); the maintainer asked for the latest bot.global.jsonkeeps SDK 10.0.403 and gainsallowPrerelease: false..github/workflows/ci.ymlkeeps the project's .NET 6.0.x runtime step (the test project targets net6.0) and takes the template's job.copilot-setup-steps.ymlgets the same .NET 6.0.x step.main.ymlnow also installs the SDKglobal.jsonpins in its three jobs: itsbuildjob failed because the runner has no SDK 10.0.403 (it installed only 6.0.x), which is unrelated to the template update.Analyzer fixes
build/Update-PublicApi.ps1 -Releaserecorded the 61 public entries inPublicAPI.Shipped.txtas a baseline only;PublicAPI.Unshipped.txtholds only#nullable enable. No library code changed.CHANGELOG.md(Keep a Changelog 1.1.0),docs/metrics.mdand the decision index say the project defines none yet.Verification
./build/dod.ps1 -Fastends withDefinition of Done: PASSED, 33 of 33 tests pass. Caveats: locally I temporarily setglobal.jsonto SDK 10.0.114 withrollForward: latestMajor(10.0.403 cannot be downloaded in this environment) and ran the tests withDOTNET_ROLL_FORWARD=Majorbecause no .NET 6 runtime is installed. Neither change is committed. CI runs the real configuration.Needs a human decision
code-review-auto-merge.ymlis new: the template's exception (ADR-0006) that auto-merges Dependabot's NCode Review pin bump. Kept, and recorded inAGENTS.md. Keep or delete it.AssemblyVersionto<major>.0.0.0(1.0.0.0for 1.x) when the project sets none. The project never set one, so releases up to 1.0.1 hadAssemblyVersionequal to the package version (for example 1.0.1.0); the next 1.x release therefore carries a lower assembly version than 1.0.1. This is disclosed inCHANGELOG.md. To keep the old behavior, set<AssemblyVersion>explicitly inDirectory.Build.props; I did not.main.ymlis also named "CI", like the template'sci.yml, and both build the project. Consider removing or renaming it (the README badge points to it)./plan-migration Backfill CHANGELOG.md from the releases v1.0.0..v1.0.1..copier-answers.ymlhaslicense: ''while the.editorconfigfile header names Apache-2.0; the answer can be set withUpdate-Project.ps1 -Data.