Repository navigation
Conversation
Co-authored-by: jliermann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the project's automation and code quality workflows. The main changes are the addition of automated formatting and commit workflows for pull requests, refactoring of existing GitHub Actions for better reusability, and the integration of pre-commit hooks for local development. These updates aim to streamline the development process, enforce consistent code style, and reduce manual intervention for formatting fixes.
GitHub Actions and Workflow Improvements:
Added a reusable composite action (
.github/actions/setup-node-env) that sets up the Node.js environment and checks out the repository, replacing repeated boilerplate in multiple workflows. The action now supports specifying a branch, tag, or SHA to check out via therefinput. [1] [2] [3] [4] [5]Refactored the
pr-check.ymlandlocalisation.ymlworkflows to use the newsetup-node-envaction, reducing duplication and simplifying maintenance. [1] [2] [3] [4]Automated Formatting and Commit Workflow:
pr-check.ymlto automatically apply Prettier fixes to changed files in pull requests targeting the main repository. If formatting changes are needed, a patch is uploaded and a new job (format-fix-commit) checks out the PR branch, applies the patch, commits the changes, and pushes them back using a GitHub App token. [1] [2]Developer Experience and Local Tooling:
huskyandlint-stagedto enforce code quality before commits. Thepreparescript inpackage.jsonsets up Husky, and a pre-commit hook runs tests and lint-staged formatting. Thelint-stagedconfiguration ensures Prettier formats relevant files before committing. [1] [2] [3] [4]Dependency Updates:
typescript-eslintto the latest patch version.