Repository navigation
fix(slurm): remove vLLM release allowlist - #1086
Merged
Merged
Conversation
Signed-off-by: Nabin Mulepati <[email protected]>
Contributor
[Medium impact] The PR appears safe to merge. SummaryRemoves the vLLM release allowlist from Slurm server resolution.
No actionable issues found. Tests were inspected, not run. Reviews (1) · Last reviewed commit: "fix(slurm): remove vLLM release allowlis..." · Reviewed by Greptile |
Contributor
|
Fern preview: https://nvidia-preview-pr-1086.docs.buildwithfern.com/nemo/datadesigner
|
12 tasks done
andreatnvidia
approved these changes
Oct 24, 2026
andreatnvidia
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Tested Qwen3.8-Flash-Next BF16 on Slurm with vLLM 0.30.0 and 8 H100s: generation and Parquet collection succeeded. Used resume: if_possible for the pre-existing dataset-directory issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Slurm rejected every vLLM image outside 0.21.x and 0.22.x during server resolution, including newer releases and model-specific development builds that users selected explicitly. Remove that release allowlist and preserve the inspected runtime version as provenance.
Targets
feat/slurm-execution.🔗 Related Issue
Related to #1085. This removes the preflight version blocker; it does not establish Qwen3.8 model compatibility or complete the live qualification requested in that issue.
🔄 Changes
Image inspection, digest verification, official requested-release matching, topology validation, and startup readiness checks remain in place. Removing the gate does not add missing model implementations to an older image or guarantee that arbitrary launch options work with every runtime.
🧪 Testing
pytest -q packages/data-designer-slurm/tests— 1,961 passed.git diff --check.make check-fern-docs— internal links across 101 pages and Fern validation passed (0 errors; 1 authentication-dependent redirects warning).✅ Checklist